Alpha GameServer attributes added to SDK #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than recreating SDK.GameServer() and SDK.WatchGameServer() in the alpha SDK, I thought it would be easiest both in the short and long term to mimic what we have done in the GameServer CRD, and populate the Alpha attributes from these SDK methods when the feature flag for Player Tracking is enabled. This is done by adding logic to the conversion function that converts the K8s GameServer definition into the SDK GameServer definition. This includes regenerated gRPC code for the supported clients. I also had to fix the line endings in the C# gen.sh, so including that in this PR.
markmandel
added
kind/feature
google-oss-robot
requested review from
devjgm,
roberthbailey and
steven-supersolid
|
Build Succeeded 👏 Build Id: 005ed5f7-70f5-4113-90aa-65711902df4a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: f6e1973f-d545-42d9-b8e0-15e2c029dd62 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
roberthbailey
approved these changes
Apr 1, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
* Alpha GameServer attributes added to SDK Rather than recreating SDK.GameServer() and SDK.WatchGameServer() in the alpha SDK, I thought it would be easiest both in the short and long term to mimic what we have done in the GameServer CRD, and populate the Alpha attributes from these SDK methods when the feature flag for Player Tracking is enabled. This is done by adding logic to the conversion function that converts the K8s GameServer definition into the SDK GameServer definition. This includes regenerated gRPC code for the supported clients. I also had to fix the line endings in the C# gen.sh, so including that in this PR. * Update based on review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than recreating SDK.GameServer() and SDK.WatchGameServer() in the alpha SDK, I thought it would be easiest both in the short and long term to mimic what we have done in the GameServer CRD, and populate the Alpha attributes from these SDK methods when the feature flag for Player Tracking is enabled.
This is done by adding logic to the conversion function that converts the K8s GameServer definition into the SDK GameServer definition.
This includes regenerated gRPC code for the supported clients.
I also had to fix the line endings in the C# gen.sh, so including that in this PR.
Work on #1033