Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Gates: EnableAllFeatures #1448

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Feature Gates: EnableAllFeatures #1448

merged 2 commits into from
Apr 6, 2020

Conversation

markmandel
Copy link
Member

@markmandel markmandel commented Apr 3, 2020 •
edited
Loading

It's can be useful for libraries that use Agones' code as a library to interact with Agones, to enable all Alpha/Beta features with one command, rather than having to track all Features that currently exists.

This provides that functionality.

@markmandel
Feature Gates: EnableAllFeatures
b7cabbc 
It's can be useful for libraries that use Agones' code as a library to
interact with Agones, it would be useful to enable all Alpha/Beta
features with one command, rather than having to track all Features that
currently exists.

This provides that functionality.
@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Apr 3, 2020
@markmandel markmandel requested a review from pooneh-m April 3, 2020 19:16
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: eb4fc47a-8a54-46d2-8567-20b1d06d1cbe

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Conformance test flakiness

Running for 10 seconds !
{"message":"shutting down sdk server","severity":"info","source":"main","time":"2020-04-03T19:27:25.717787096Z"}
{"message":"Compare","severity":"info","time":"2020-04-03T19:27:25.71787636Z"}
{"message":"Testing Failed [ready allocate setlabel setannotation gameserver health shutdown watch reserve] [watch ready reserve allocate health setlabel setannotation shutdown]","severity":"info","time":"2020-04-03T19:27:25.717922468Z"}
includes/sdk.mk:141: recipe for target 'run-sdk-conformance-no-build' failed
make[2]: *** [run-sdk-conformance-no-build] Error 1
make[1]: *** [run-sdk-conformance-test] Error 2
includes/sdk.mk:148: recipe for target 'run-sdk-conformance-test' failed
make: *** [run-sdk-conformance-test-go] Error 2

We might want to do some work in conformance tests to make it easier to work out which one is failing.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2255437e-c7e5-4db4-bae8-f997c4745c61

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1448/head:pr_1448 && git checkout pr_1448
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-b7cabbc

@aLekSer
Copy link
Collaborator

aLekSer commented Apr 4, 2020

Yes, that SDK Conformance test output is really hard to track. I will work on this.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 24eecda4-10ef-470d-a73f-53f8ae84bd6a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 445db24d-5601-44ca-ad85-8275b6698db8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1d8a6124-1909-4d35-a17a-4c07f1739573

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1448/head:pr_1448 && git checkout pr_1448
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-d73ae73

@markmandel markmandel merged commit 5181327 into googleforgames:master Apr 6, 2020
@markmandel markmandel deleted the feature/enable-all-features branch April 6, 2020 19:05
@markmandel markmandel added this to the 1.5.0 milestone Apr 6, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @roberthbailey @ilkercelikyilmaz
Feature Gates: EnableAllFeatures (googleforgames#1448)
3bd50bc 
It's can be useful for libraries that use Agones' code as a library to
interact with Agones, it would be useful to enable all Alpha/Beta
features with one command, rather than having to track all Features that
currently exists.

This provides that functionality.

Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@roberthbailey roberthbailey

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones size/M
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markmandel @agones-bot @aLekSer @google-oss-robot @roberthbailey