Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST SDK Conformance Tests #1537

Merged
merged 1 commit into from
May 12, 2020
Merged

REST SDK Conformance Tests #1537

merged 1 commit into from
May 12, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Conformance tests for the REST API.

Which issue(s) this PR fixes:

Work on #1507

Special notes for your reviewer:
None.

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels May 11, 2020
markmandel
markmandel commented May 11, 2020
View reviewed changes
cmd/sdk-server/main.go Outdated
logger.WithError(err).Fatal("Could not register grpc-gateway")
logger.WithError(err).Fatal("Could not register sdk grpc-gateway")
}
if err = sdkalpha.RegisterSDKHandler(ctx, mux, conn); err != nil {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't add the beta SDK in here, as with no services, no RegisterSDKHandler function gets generated for the beta SDK.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 351d3fa0-e13d-4c5a-98f3-c9ac2a401416

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1537/head:pr_1537 && git checkout pr_1537
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-cda524c

roberthbailey
roberthbailey reviewed May 11, 2020
View reviewed changes
test/sdk/restapi/http-api-test.go.nolint Outdated
@@ -105,6 +112,56 @@ func main() {
log.Fatalf("Could not SetAnnotation: %v\n", err)
}

// easy feature flag check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: needs formatting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

cmd/sdk-server/main.go Outdated
logger.WithError(err).Fatal("Could not register grpc-gateway")
logger.WithError(err).Fatal("Could not register sdk grpc-gateway")
}
if err = sdkalpha.RegisterSDKHandler(ctx, mux, conn); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if err := ...; err != nil

test/sdk/restapi/http-api-test.go.nolint Show resolved Hide resolved
@markmandel markmandel force-pushed the tests/rest-api-conformance branch from cda524c to eef2bd7 Compare May 12, 2020 00:11
@markmandel
REST SDK Conformance Tests
d005674 
Conformance tests for the REST API.

Work on googleforgames#1507
@markmandel markmandel force-pushed the tests/rest-api-conformance branch from eef2bd7 to d005674 Compare May 12, 2020 01:40
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 401ed8ab-efba-49e7-8bed-722900bbaec9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e72b84e5-959f-4b9b-8fb6-8f188e98722f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1537/head:pr_1537 && git checkout pr_1537
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-d005674

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit f491005 into googleforgames:master May 12, 2020
@markmandel markmandel deleted the tests/rest-api-conformance branch May 12, 2020 13:25
@markmandel markmandel added this to the 1.6.0 milestone May 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
REST SDK Conformance Tests (googleforgames#1537)
2522603 
Conformance tests for the REST API.

Work on googleforgames#1507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@roberthbailey roberthbailey

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones lgtm size/M
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey