CRD values for Aggregate Player Tracking #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/feature
|
Build Succeeded 👏 Build Id: bf9a4f9a-671b-42f5-901f-217429db43b5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
pooneh-m
suggested changes
May 15, 2020
pkg/apis/agones/v1/common.go
Outdated
| @@ -35,6 +35,12 @@ const ( | |||
| ErrContainerNameInvalid = "Container must be empty or the name of a container in the pod template" | |||
| ) | |||
|
|
|||
| // AggregatePlayerStatus stores total player tracking values | |||
| type AggregatePlayerStatus struct { | |||
There was a problem hiding this comment.
Aggregated works for me. Changed.
pkg/apis/agones/v1/fleet.go
Outdated
| // [FeatureFlag:PlayerTracking] | ||
| // Players are the current total player capacity and count for this Fleet | ||
| // +optional | ||
| Players *AggregatePlayerStatus `json:"players"` |
pkg/apis/agones/v1/gameserverset.go
Outdated
| // [FeatureFlag:PlayerTracking] | ||
| // Players are the current total player capacity and count for this GameServerSet | ||
| // +optional | ||
| Players *AggregatePlayerStatus `json:"players"` |
This PR is only the structure to store aggregate values for player tracking data across Fleets and GameServerSets. Later PRs will implement the logic. Work on googleforgames#1033
markmandel
force-pushed
the
feature/fleet-aggregate
branch
from
5bd6739 to
413ddc2
Compare
pooneh-m
approved these changes
May 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, pooneh-m The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Nice! |
|
Build Succeeded 👏 Build Id: eff3391a-0372-4003-8d62-6ccfddda4b85 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
This PR is only the structure to store aggregate values for player tracking data across Fleets and GameServerSets. Later PRs will implement the logic. Work on googleforgames#1033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This PR is only the structure to store aggregate values for player tracking data across Fleets and GameServerSets.
Which issue(s) this PR fixes:
Work on #1033
Special notes for your reviewer:
Later PRs will implement the logic.