Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm 3 Install Documentation #1627

Merged
merged 3 commits into from
Jun 24, 2020
Merged

Helm 3 Install Documentation #1627

merged 3 commits into from
Jun 24, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:
Split Helm install documentation into Helm 3 and Helm 2 - deliberately
putting Helm 3 at the top, since we would like to push people that way.

Which issue(s) this PR fixes:
Closes #1494
Work on #1436

Special notes for your reviewer:
None.

@markmandel markmandel added kind/feature New features for Agones kind/documentation Documentation for Agones labels Jun 17, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 23176c6d-77a4-4910-bd74-e9bf7aa22f85

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1627/head:pr_1627 && git checkout pr_1627
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-af32c12

@markmandel
Copy link
Member Author

Preview of changes:
https://af32c12-dot-preview-dot-agones-images.appspot.com/site/docs/installation/install-agones/helm/

@felipeota - this better?

@felipeota
Copy link

Preview of changes:
https://af32c12-dot-preview-dot-agones-images.appspot.com/site/docs/installation/install-agones/helm/

@felipeota - this better?

That's it!

@markmandel
Helm 3 Install Documentation
4a06323 
Split Helm install documentation into Helm 3 and Helm 2 - deliberately
putting Helm 3 at the top, since we would like to push people that way.

Closes googleforgames#1494
Work on googleforgames#1436
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 11071548-5a7e-4dd3-a7ac-7774574e5364

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1627/head:pr_1627 && git checkout pr_1627
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-02d4368

@markmandel
Copy link
Member Author

Updated:
https://02d4368-dot-preview-dot-agones-images.appspot.com/site/docs/installation/install-agones/helm/

TBBle
TBBle reviewed Jun 23, 2020
View reviewed changes
site/content/en/docs/Installation/Install Agones/helm.md Outdated
$ cd install/helm/
$ helm install --name my-release --namespace agones-system agones --set agones.image.tag={{< release-version >}}-481970d
$ kubectl create namespace ps4
$ helm upgrade my-release agones/agones --set "gameservers.namespaces={default,xbox,ps4}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, we might want to add --reuse-values to this command-line, so that people using it don't accidentally remove other settings that have been applied to the Helm chart.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, that's an excellent suggestion. Making this adjustment now!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fbf36ffa-c287-471e-a9f7-9c054dc42844

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1627/head:pr_1627 && git checkout pr_1627
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-20b650b

@markmandel
Copy link
Member Author

Done:
https://20b650b-dot-preview-dot-agones-images.appspot.com/site/docs/installation/install-agones/helm/

@markmandel markmandel mentioned this pull request Jun 23, 2020
Closed
@markmandel
Copy link
Member Author

Gentle bump - anything else that needs changing in here?

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@markmandel
Copy link
Member Author

Thank you! 😄

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8ebf0627-bede-4ae7-adc4-24dacacf131d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Arg.

/usr/share/dotnet/sdk/2.2.402/NuGet.targets(123,5): error : The file '/go/src/agones.dev/agones/sdks/csharp/sdk/obj/csharp-sdk.csproj.nuget.g.props' already exists. [/go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj]
make[1]: *** [run-sdk-command] Error 1
includes/sdk.mk:88: recipe for target 'run-sdk-command' failed
includes/sdk.mk:84: recipe for target 'run-sdk-command-csharp' failed
make: *** [run-sdk-command-csharp] Error 2

Need to work out what is up there.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 73145712-dc5d-4a0c-a140-5f663744d339

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ba42ab76-3419-492d-918c-4c899bd09ca3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1627/head:pr_1627 && git checkout pr_1627
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-a377755

@markmandel markmandel merged commit c8d6dd4 into googleforgames:master Jun 24, 2020
@markmandel markmandel deleted the site/helm3 branch June 24, 2020 21:30
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Helm 3 Install Documentation (googleforgames#1627)
e571dbb 
* Helm 3 Install Documentation

Split Helm install documentation into Helm 3 and Helm 2 - deliberately
putting Helm 3 at the top, since we would like to push people that way.

Closes googleforgames#1494
Work on googleforgames#1436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TBBle TBBle TBBle left review comments

@roberthbailey roberthbailey roberthbailey approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@roberthbailey roberthbailey

Labels
approved cla: yes kind/documentation Documentation for Agones kind/feature New features for Agones size/L
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Outdated and incomplete instructions on installing Agones using Helm
7 participants
@markmandel @agones-bot @felipeota @google-oss-robot @TBBle @roberthbailey @googlebot