Flakey test fix: TestControllerUpdateFleetStatus #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this will stop this test being flakey.
markmandel
added
kind/cleanup
|
Build Succeeded 👏 Build Id: 7a4a0ad2-c747-4565-92a7-afe7ddb7da37 The following development artifacts have been built, and will exist for the next 30 days:
|
markmandel
removed
the
area/build-tools
EricFortin
reviewed
Jun 13, 2018
| @@ -341,7 +341,7 @@ func TestControllerUpdateFleetStatus(t *testing.T) { | |||
| return true, fleet, nil | |||
| }) | |||
|
|
|||
| _, cancel := agtesting.StartInformers(m, c.fleetSynced) | |||
| _, cancel := agtesting.StartInformers(m, c.fleetSynced, c.gameServerSetSynced) | |||
EricFortin
approved these changes
Jun 13, 2018
|
Build Succeeded 👏 Build Id: 1084a0f9-8604-4c24-a28b-f645afbdaa24 The following development artifacts have been built, and will exist for the next 30 days:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will stop this test being flakey.