Added Agones Category to all UPROPERTY macro #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unreal currently requires all UPROPERTY to have a Category. This change adds the "Agones" category to all UPROPERTY's exposed in Classes.h. It allows the AgonesSDK to be added to as an Engine Plugin or Project Plugin. The motivation behind this was so Custom Online Subsystems can reference the Agones code properly.
|
Build Succeeded 👏 Build Id: 6b6e82a8-104f-4c60-9df3-04faed8f7ae9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
added
kind/feature
|
Calling on our usual Unreal people - @highlyunavailable @domgreen -- thoughts? |
|
Good and correct. 👍 from me. |
roberthbailey
approved these changes
May 19, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Dinhh1, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / Why we need it:
Unreal currently requires all UPROPERTY to have a Category for Engine Plugins.
This change adds the "Agones" category to all UPROPERTY's exposed in
Classes.h. It allows the AgonesSDK to be added to as an Engine Plugin or
Project Plugin. The motivation behind this was so Custom Online Subsystems
can reference the Agones code properly.
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer:
Unreal Build Log:
Build started 5/18/2022 9:51:48 AM.
Logging verbosity is set to: Normal.Project "D:\build\UnrealTutorials\AgonesBuild\AgonesBuild.sln" on node 1 (Rebuild target(s)).
ValidateSolutionConfiguration:
Building solution configuration "Development Editor|Win64".
ValidateProjects:
The project "UE4" is not selected for building in solution configuration "Development Editor|Win64".
Project "D:\build\UnrealTutorials\AgonesBuild\AgonesBuild.sln" (1) is building "D:\build\UnrealTutorials\AgonesBuild\Intermediate\ProjectFiles\AgonesBuild.vcxproj" (2) on node 1 (Rebuild target(s)).
Rebuild:
D:\Unreal\UE_4.27\Engine\Build\BatchFiles\Rebuild.bat AgonesBuildEditor Win64 Development -Project="D:\build\UnrealTutorials\AgonesBuild\AgonesBuild.uproject" -WaitMutex -FromMsBuild
Cleaning AgonesBuildEditor and UnrealHeaderTool binaries...
Creating makefile for AgonesBuildEditor (no existing makefile)
Parsing headers for AgonesBuildEditor
Running UnrealHeaderTool "D:\build\UnrealTutorials\AgonesBuild\AgonesBuild.uproject" "D:\build\UnrealTutorials\AgonesBuild\Intermediate\Build\Win64\AgonesBuildEditor\Development\AgonesBuildEditor.uhtmanifest" -LogCmds="loginit warning, logexit warning, logdatabase error" -Unattended -WarningsAsErrors -abslog="C:\Users\hod1\AppData\Local\UnrealBuildTool\Log_UHT.txt" -installed
LogInit: Display: Loading text-based GConfig....
Reflection code generated for AgonesBuildEditor in 4.5467708 seconds
Building AgonesBuildEditor...
Using Visual Studio 2019 14.29.30138 toolchain (C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.29.30133) and Windows 10.0.22000.0 SDK (C:\Program Files (x86)\Windows Kits\10).
Building 11 actions with 8 processes...
[1/11] Default.rc2
[2/11] SharedPCH.Engine.ShadowErrors.cpp
[3/11] AgonesBuild.cpp
[4/11] AgonesBuild.init.gen.cpp
[5/11] AgonesBuildGameMode.cpp
[6/11] AgonesBuildGameMode.gen.cpp
[7/11] AgonesBuildCharacter.gen.cpp
[8/11] AgonesBuildCharacter.cpp
[9/11] UE4Editor-AgonesBuild.lib
Creating library D:\build\UnrealTutorials\AgonesBuild\Intermediate\Build\Win64\UE4Editor\Development\AgonesBuild\UE4Editor-AgonesBuild.lib and object D:\build\UnrealTutorials\AgonesBuild\Intermediate\Build\Win64\UE4Editor\Development\AgonesBuild\UE4Editor-AgonesBuild.exp
[10/11] UE4Editor-AgonesBuild.dll
Creating library D:\build\UnrealTutorials\AgonesBuild\Intermediate\Build\Win64\UE4Editor\Development\AgonesBuild\UE4Editor-AgonesBuild.suppressed.lib and object D:\build\UnrealTutorials\AgonesBuild\Intermediate\Build\Win64\UE4Editor\Development\AgonesBuild\UE4Editor-AgonesBuild.suppressed.exp
[11/11] AgonesBuildEditor.target
Total time in Parallel executor: 28.41 seconds
Total execution time: 35.71 seconds
Done Building Project "D:\build\UnrealTutorials\AgonesBuild\Intermediate\ProjectFiles\AgonesBuild.vcxproj" (Rebuild target(s)).
Done Building Project "D:\build\UnrealTutorials\AgonesBuild\AgonesBuild.sln" (Rebuild target(s)).
Build succeeded.
0 Warning(s)
0 Error(s)