e2e tests for arm64 simple game server #2604

Ludea · 2022-05-30T11:07:15Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
e2e tests for simple game server on arm64 hosts

Which issue(s) this PR fixes:

Works on #2216

Special notes for your reviewer:

agones-bot · 2022-05-30T11:33:21Z

Build Succeeded 👏

Build Id: 12e81555-afa6-45fe-b943-de5fb2a6067b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-f909273-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-f909273-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-f909273
Linux C++ SDK (build): agonessdk-1.24.0-f909273-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-f909273.zip

A preview of the website (the last 30 builds are retained):

https://f909273-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2604/head:pr_2604 && git checkout pr_2604
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-f909273-amd64

agones-bot · 2022-05-31T06:30:31Z

Build Failed 😱

Build Id: ea409843-c641-4ba9-b420-8b478ee2fc8c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-05-31T08:35:23Z

Build Succeeded 👏

Build Id: 2b192cff-39b8-43c0-a770-55b4e71ed209

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-f2c1a0c-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-f2c1a0c-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-f2c1a0c-amd64
image: gcr.io/agones-images/agones-ping:1.24.0-f2c1a0c-arm64
Linux C++ SDK (build): agonessdk-1.24.0-f2c1a0c-arm64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-f2c1a0c-arm64.zip

A preview of the website (the last 30 builds are retained):

https://f2c1a0c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2604/head:pr_2604 && git checkout pr_2604
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-f2c1a0c-amd64

examples/simple-game-server/Makefile

roberthbailey · 2022-05-31T14:31:33Z

examples/simple-game-server/Makefile

@@ -41,6 +43,10 @@ server_tag_linux_amd64 = $(server_tag)-linux_amd64
 else
 server_tag_linux_amd64 = $(server_tag)
 endif
+ifeq ($(WITH_ARM64), 1)


I think the above lines should be changed in the same way you changed the tag generation for the controller/allocator/ping images so that we always push a multi-arch manifest (even if both WITH_WINDOWS and WITH_ARM are false). Right now if WITH_WINDOWS is false then server_tag_linux_amd64 = $(server_tag) which I don't think will work if WITH_ARM is set to true at the same time.

examples/simple-game-server/Makefile

agones-bot · 2022-05-31T14:55:35Z

Build Failed 😱

Build Id: fef3321e-3511-4f10-a410-1c2bf291199a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-05-31T14:55:35Z

Build Failed 😱

Build Id: 994004c2-722d-4aee-b4ed-49b27c81aa9e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-05-31T15:07:48Z

Build Failed 😱

Build Id: 1b1f074f-9334-4f52-99f9-485051c44638

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-05-31T15:22:29Z

Build Succeeded 👏

Build Id: 1fdc05cc-2e2f-4924-b70c-3b80cc0ee9d0

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-9699157-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-9699157-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-9699157-amd64
image: gcr.io/agones-images/agones-ping:1.24.0-9699157-arm64
Linux C++ SDK (build): agonessdk-1.24.0-9699157-arm64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-9699157-arm64.zip

A preview of the website (the last 30 builds are retained):

https://9699157-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2604/head:pr_2604 && git checkout pr_2604
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-9699157-amd64

roberthbailey · 2022-05-31T15:21:37Z

examples/simple-game-server/Makefile

+push: push-image
+build: build-linux-image-amd64
+
+ifeq ($(WITH_WINDOWS), 1)
 build: build-linux-image $(foreach winver, $(WINDOWS_VERSIONS), build-windows-image-$(winver))


build-linux-image no longer exists.

Delete this step

roberthbailey · 2022-05-31T15:22:44Z

examples/simple-game-server/Makefile

+push_server_manifest += $(server_tag_linux_arm64)
+endif
+
+push: push-image


Is there a reason to have both push and push-image targets? Can we remove this and rename the push-image ones below to push?

I delete redondant target

agones-bot · 2022-05-31T16:27:34Z

Build Succeeded 👏

Build Id: 7d427164-cdd9-4d08-ab12-f493ec76e41a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-c801f1b-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-c801f1b-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-c801f1b-amd64
image: gcr.io/agones-images/agones-ping:1.24.0-c801f1b-arm64
Linux C++ SDK (build): agonessdk-1.24.0-c801f1b-arm64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-c801f1b-arm64.zip

A preview of the website (the last 30 builds are retained):

https://c801f1b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2604/head:pr_2604 && git checkout pr_2604
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-c801f1b-amd64

agones-bot · 2022-05-31T16:47:33Z

Build Failed 😱

Build Id: 4aba1151-fed8-4d6a-ac89-1a30770cbd8b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-05-31T17:11:20Z

Build Failed 😱

Build Id: 52ee71e9-bb53-4304-a835-0bfd7fddceae

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2022-05-31T17:59:36Z

sdk-conformance failed again.

Trying to grab relevant errors I found:

2022/05/31 17:07:54 Connecting to ws://localhost:9101/watch/gameserver
{"message":"Connected to watch GameServer...","sdkName":"restapi","severity":"info","source":"*sdkserver.LocalSDKServer","time":"2022-05-31T17:07:54.680877044Z"}
{"message":"Setting label","sdkName":"restapi","severity":"info","source":"*sdkserver.LocalSDKServer","time":"2022-05-31T17:07:54.681364972Z","values":{"key":"testws","value":"true"}}
{"message":"expected to receive '1654016873' as value for 'setlabel' request but received 'true'","sdkName":"restapi","severity":"error","source":"*sdkserver.LocalSDKServer","time":"2022-05-31T17:07:54.681419736Z"}
{"message":"Gameserver update received","sdkName":"restapi","severity":"info","source":"*sdkserver.LocalSDKServer","time":"2022-05-31T17:07:54.681455144Z"}
{"error":"rpc error: code = Canceled desc = context canceled","message":"error sending gameserver","sdkName":"restapi","severity":"error","source":"*sdkserver.LocalSDKServer","time":"2022-05-31T17:07:54.68153426Z"}
2022/05/31 17:07:54 Received message from websocket: {"result":{"object_meta":{"name":"local","namespace":"default","uid":"2488478064806900514","resource_version":"v1","generation":"1","creation_timestamp":"1654016873","annotations":{"agones.dev/sdk-UID":"2488478064806900514","annotation":"true"},"labels":{"agones.dev/sdk-creationTimestamp":"1654016873","islocal":"true"}},"spec":{"health":{"period_seconds":3,"failure_threshold":5,"initial_delay_seconds":10}},"status":{"state":"Shutdown","address":"127.0.0.1","ports":[{"name":"default","port":7777}],"players":{"capacity":"10"}}}}
2022/05/31 17:07:54 Could not find label 'agones.dev/sdk-testws' in message
time="2022-05-31T17:07:54Z" level=warning msg="error reading websocket message: read tcp [::1]:9101->[::1]:42000: read: connection reset by peer"
exit status 1
make[2]: *** [includes/sdk.mk:88: run-sdk-command] Error 1

and

make[2]: *** [includes/sdk.mk:145: run-sdk-conformance-no-build] Error 1
make[1]: *** [includes/sdk.mk:153: run-sdk-conformance-test] Error 2
make: *** [includes/sdk.mk:156: run-sdk-conformance-test-cpp] Error 2

agones-bot · 2022-05-31T18:25:46Z

Build Failed 😱

Build Id: 45f32dbd-6a82-4e14-934e-118763eac0b3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2022-05-31T18:27:10Z

Different flake:

--- FAIL: TestGameServerAllocationDuringGameServerDeletion (0.00s)
    --- FAIL: TestGameServerAllocationDuringGameServerDeletion/scale_down (15.60s)
        fleet_test.go:854: 
            	Error Trace:	fleet_test.go:854
            	            				fleet_test.go:866
            	Error:      	Should NOT be empty, but was []
            	Test:       	TestGameServerAllocationDuringGameServerDeletion/scale_down

agones-bot · 2022-05-31T18:44:18Z

Build Failed 😱

Build Id: 7a977a96-f7c6-4d55-8b1d-eecbdcfee1de

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-05-31T19:14:49Z

Build Succeeded 👏

Build Id: 8cd12307-c36a-4de9-ac96-06494caeb1f7

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-44af679-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-44af679-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-44af679-amd64
image: gcr.io/agones-images/agones-ping:1.24.0-44af679-arm64
Linux C++ SDK (build): agonessdk-1.24.0-44af679-arm64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-44af679-arm64.zip

A preview of the website (the last 30 builds are retained):

https://44af679-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2604/head:pr_2604 && git checkout pr_2604
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-44af679-amd64

google-oss-prow · 2022-05-31T20:55:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ludea, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

e2e tests into non native arm64 hosts

f909273

google-oss-prow bot requested review from aLekSer and pooneh-m May 30, 2022 11:07

google-oss-prow bot added the size/M label May 30, 2022

Merge branch 'main' into e2e_tests_arm64

6158cd7

Merge branch 'main' into e2e_tests_arm64

f2c1a0c

Merge branch 'main' into e2e_tests_arm64

93a34a3

roberthbailey reviewed May 31, 2022

View reviewed changes

roberthbailey self-assigned this May 31, 2022

Ludea added 2 commits May 31, 2022 16:40

Bump to 0.13

73ba075

better tag

9675b11

use Windows builder

9699157

roberthbailey reviewed May 31, 2022

View reviewed changes

Remove redondant step

c801f1b

Fix Windows build

3d4123e

Set os version flag

5c20585

Debug

44af679

roberthbailey approved these changes May 31, 2022

View reviewed changes

google-oss-prow bot added the lgtm label May 31, 2022

google-oss-prow bot added the approved label May 31, 2022

roberthbailey merged commit cb7c28c into googleforgames:main May 31, 2022

SaitejaTamma added this to the 1.24.0 milestone Jun 14, 2022

SaitejaTamma added the kind/feature New features for Agones label Jun 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

e2e tests for arm64 simple game server #2604

e2e tests for arm64 simple game server #2604

Ludea commented May 30, 2022

agones-bot commented May 30, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

roberthbailey May 31, 2022

Ludea May 31, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

roberthbailey May 31, 2022

Ludea May 31, 2022

roberthbailey May 31, 2022

Ludea May 31, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

roberthbailey commented May 31, 2022

agones-bot commented May 31, 2022

roberthbailey commented May 31, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

google-oss-prow bot commented May 31, 2022

e2e tests for arm64 simple game server #2604

e2e tests for arm64 simple game server #2604

Conversation

Ludea commented May 30, 2022

agones-bot commented May 30, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

roberthbailey May 31, 2022

Choose a reason for hiding this comment

Ludea May 31, 2022

Choose a reason for hiding this comment

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

roberthbailey May 31, 2022

Choose a reason for hiding this comment

Ludea May 31, 2022

Choose a reason for hiding this comment

roberthbailey May 31, 2022

Choose a reason for hiding this comment

Ludea May 31, 2022

Choose a reason for hiding this comment

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

roberthbailey commented May 31, 2022

agones-bot commented May 31, 2022

roberthbailey commented May 31, 2022

agones-bot commented May 31, 2022

agones-bot commented May 31, 2022

google-oss-prow bot commented May 31, 2022