Move CustomFasSyncInterval to Beta #2654

govargo · 2022-06-30T16:01:08Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

This PR bump up CustomFasSyncInterval from Alpha to Beta.

Which issue(s) this PR fixes:

Closes #2646

Special notes for your reviewer:

None

agones-bot · 2022-06-30T16:27:30Z

Build Succeeded 👏

Build Id: 9d6c8f3c-da93-4344-905d-5277be1fb705

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://b2b84e3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2654/head:pr_2654 && git checkout pr_2654
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.25.0-b2b84e3-amd64

govargo · 2022-07-04T15:56:41Z

Pending: #2646 (comment)

markmandel · 2022-07-08T20:59:13Z

@govargo did you want review on this? Just figured I would ask first since it had "WIP" in the title 😄

Lemme know if this PR is ready for review or not.

govargo · 2022-07-11T06:49:17Z

@markmandel Thank you for your comment.
I removed WIP from this PR title and rebased latest main repository.
Now, it's ready for review.

agones-bot · 2022-07-11T07:14:42Z

Build Succeeded 👏

Build Id: c057e00a-a077-4d40-a64d-5086cc3a47a1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://dce5862-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2654/head:pr_2654 && git checkout pr_2654
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.25.0-dce5862-amd64

markmandel

Just doing a quick search, also found:

agones/examples/fleetautoscaler.yaml

Lines 50 to 53 in 73cdabc

    
           # [Stage:Alpha] 
        
           # [FeatureFlag:CustomFasSyncInterval] 
        
           # The autoscaling sync strategy 
        
           sync:

We will need to regen the crd reference (the tests will fail) with the yaml update:
https://github.com/googleforgames/agones/blob/main/build/README.md#make-gen-api-docs

agones/pkg/apis/autoscaling/v1/fleetautoscaler.go

Lines 57 to 62 in 73cdabc

    
           	// [Stage:Alpha] 
        
           	// [FeatureFlag:CustomFasSyncInterval] 
        
           	// Sync defines when FleetAutoscalers runs autoscaling 
        
           	// +optional 
        
           	Sync *FleetAutoscalerSync `json:"sync,omitempty"` 
        
           }

markmandel · 2022-07-13T22:47:54Z

site/content/en/docs/Guides/feature-stages.md

@@ -29,7 +29,7 @@ The current set of `alpha` and `beta` feature gates are:
 |--------------|---------|---------|-------|-------|
 | Example Gate (not in use) | `Example` | Disabled | None | 0.13.0 |
 | [Player Tracking]({{< ref "/docs/Guides/player-tracking.md" >}}) | `PlayerTracking` | Disabled | `Alpha` | 1.6.0 |
-| [Custom resync period for FleetAutoscaler](https://github.com/googleforgames/agones/issues/1955) | `CustomFasSyncInterval` | Disabled | `Alpha` | 1.17.0 |
+| [Custom resync period for FleetAutoscaler](https://github.com/googleforgames/agones/issues/1955) | `CustomFasSyncInterval` | Enabled | `Beta` | 1.25.0 |


You'll see to do a feature shortcode the table:

https://agones.dev/site/docs/contribute/#within-a-page

Added feature shortcode. If more fixs are needed, please let me know.

markmandel · 2022-07-13T22:48:07Z

site/content/en/docs/Reference/fleetautoscaler.md

@@ -37,7 +37,7 @@ spec:
      # maximum fleet size that can be set by this FleetAutoscaler
      # required
      maxReplicas: 20
-  # [Stage:Alpha]
+  # [Stage:Beta]


You will also need to feature shortcode the example:

https://agones.dev/site/docs/contribute/#within-a-page

Added feature shortcode. If more fixs are needed, please let me know.

agones-bot · 2022-07-14T09:16:46Z

Build Succeeded 👏

Build Id: e2a93ef2-93c7-42d4-a809-01874144d466

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://f381882-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2654/head:pr_2654 && git checkout pr_2654
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.25.0-f381882-amd64

govargo · 2022-07-14T09:24:25Z

Done make gen-api-docs

https://f381882-dot-preview-dot-agones-images.appspot.com/site/docs/reference/agones_crd_api_reference/

markmandel

LGTM!

google-oss-prow · 2022-07-14T22:38:01Z

New changes are detected. LGTM label has been removed.

google-oss-prow · 2022-07-14T22:38:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: govargo, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2022-07-14T23:05:42Z

Build Succeeded 👏

Build Id: 51c09616-2db5-457b-a484-30e86ae5208d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://d8df4d0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2654/head:pr_2654 && git checkout pr_2654
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.25.0-d8df4d0-amd64

google-oss-prow bot requested review from EricFortin and markmandel June 30, 2022 16:01

google-oss-prow bot added the size/S label Jun 30, 2022

RY-2718 mentioned this pull request Jul 4, 2022

Move CustomFasSyncInterval to Beta #2646

Closed

govargo changed the title ~~Move CustomFasSyncInterval to Beta~~ WIP: Move CustomFasSyncInterval to Beta Jul 4, 2022

google-oss-prow bot added the do-not-merge/work-in-progress label Jul 4, 2022

SaitejaTamma added the kind/feature New features for Agones label Jul 6, 2022

govargo changed the title ~~WIP: Move CustomFasSyncInterval to Beta~~ Move CustomFasSyncInterval to Beta Jul 11, 2022

google-oss-prow bot removed the do-not-merge/work-in-progress label Jul 11, 2022

markmandel reviewed Jul 13, 2022

View reviewed changes

Move CustomFasSyncInterval to Beta

f381882

google-oss-prow bot added size/XXL and removed size/S labels Jul 14, 2022

markmandel approved these changes Jul 14, 2022

View reviewed changes

google-oss-prow bot assigned markmandel Jul 14, 2022

google-oss-prow bot added the lgtm label Jul 14, 2022

Merge branch 'main' into customfassyncinterval-beta

d8df4d0

google-oss-prow bot removed the lgtm label Jul 14, 2022

google-oss-prow bot added the approved label Jul 14, 2022

markmandel merged commit 163030b into googleforgames:main Jul 14, 2022

SaitejaTamma added this to the 1.25.0 milestone Jul 26, 2022

govargo deleted the customfassyncinterval-beta branch October 28, 2022 04:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move CustomFasSyncInterval to Beta #2654

Move CustomFasSyncInterval to Beta #2654

govargo commented Jun 30, 2022

agones-bot commented Jun 30, 2022

govargo commented Jul 4, 2022

markmandel commented Jul 8, 2022

govargo commented Jul 11, 2022

agones-bot commented Jul 11, 2022

markmandel left a comment •

edited

Loading

markmandel Jul 13, 2022

govargo Jul 14, 2022

markmandel Jul 13, 2022

govargo Jul 14, 2022

agones-bot commented Jul 14, 2022

govargo commented Jul 14, 2022 •

edited

Loading

markmandel left a comment

google-oss-prow bot commented Jul 14, 2022

google-oss-prow bot commented Jul 14, 2022

agones-bot commented Jul 14, 2022

	# [Stage:Alpha]
	# [FeatureFlag:CustomFasSyncInterval]
	# The autoscaling sync strategy
	sync:

	// [Stage:Alpha]
	// [FeatureFlag:CustomFasSyncInterval]
	// Sync defines when FleetAutoscalers runs autoscaling
	// +optional
	Sync *FleetAutoscalerSync `json:"sync,omitempty"`
	}

Move CustomFasSyncInterval to Beta #2654

Move CustomFasSyncInterval to Beta #2654

Conversation

govargo commented Jun 30, 2022

agones-bot commented Jun 30, 2022

govargo commented Jul 4, 2022

markmandel commented Jul 8, 2022

govargo commented Jul 11, 2022

agones-bot commented Jul 11, 2022

markmandel left a comment • edited Loading

Choose a reason for hiding this comment

markmandel Jul 13, 2022

Choose a reason for hiding this comment

govargo Jul 14, 2022

Choose a reason for hiding this comment

markmandel Jul 13, 2022

Choose a reason for hiding this comment

govargo Jul 14, 2022

Choose a reason for hiding this comment

agones-bot commented Jul 14, 2022

govargo commented Jul 14, 2022 • edited Loading

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Jul 14, 2022

google-oss-prow bot commented Jul 14, 2022

agones-bot commented Jul 14, 2022

markmandel left a comment •

edited

Loading

govargo commented Jul 14, 2022 •

edited

Loading