Upgrade Agones to Kubernetes 1.23 #2711

roberthbailey · 2022-08-17T06:28:26Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: A series of commits to accomplish all of the code changes necessary to upgrade Agones to Kubernetes 1.23.

Which issue(s) this PR fixes:

Part of #2642

Special notes for your reviewer:
In the past I've done the steps as sequential pull requests. This time I took what would have been 7 PRs and combined them into a single PR with 7 commits. This should be reviewed one commit at a time (the client-go updates a lot of files in the vendor directory).

agones-bot · 2022-08-17T06:37:58Z

Build Failed 😱

Build Id: f1cd73a7-5566-4020-83df-e214698de6f4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-08-22T21:35:33Z

Build Failed 😱

Build Id: 65d7c84e-360f-4c4f-b3f0-fd5b09dddd02

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2022-08-22T21:50:27Z

Looks like a test flake, since this is passing locally for me:

--- FAIL: TestSDKServerReserveTimeout (3.25s)
    sdkserver_test.go:954: 
        	Error Trace:	sdkserver_test.go:954
        	            				sdkserver_test.go:947
        	            				sdkserver_test.go:963
        	Error:      	Not equal: 
        	            	expected: time.Date(2022, time.August, 22, 21, 9, 44, 0, time.Local)
        	            	actual  : time.Date(2022, time.August, 22, 21, 9, 43, 0, time.Local)
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -2,3 +2,3 @@
        	            	  wall: (uint64) 0,
        	            	- ext: (int64) 63796799384,
        	            	+ ext: (int64) 63796799383,
        	            	  loc: (*time.Location)({
        	Test:       	TestSDKServerReserveTimeout

agones-bot · 2022-08-22T22:23:53Z

Build Succeeded 👏

Build Id: c0ede083-e5dc-4628-8494-4f793ed192c1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.26.0-c6e8911-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.26.0-c6e8911-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.26.0-c6e8911-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.26.0-c6e8911-amd64
Linux C++ SDK (build): agonessdk-1.26.0-c6e8911-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.26.0-c6e8911-amd64.zip

A preview of the website (the last 30 builds are retained):

https://c6e8911-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2711/head:pr_2711 && git checkout pr_2711
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-c6e8911-amd64

$ go get k8s.io/client-go@v0.23.9 $ go mod tidy $ go mod vendor

by `make gen-crd-client`.

for Kubernetes 1.23.

agones-bot · 2022-08-24T16:40:16Z

Build Succeeded 👏

Build Id: 64966daa-76a1-4d6a-a58c-fe37e935a679

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.26.0-75177f7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.26.0-75177f7-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.26.0-75177f7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.26.0-75177f7-amd64
Linux C++ SDK (build): agonessdk-1.26.0-75177f7-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.26.0-75177f7-amd64.zip

A preview of the website (the last 30 builds are retained):

https://75177f7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2711/head:pr_2711 && git checkout pr_2711
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-75177f7-amd64

markmandel · 2022-08-24T21:27:42Z

go.mod

@@ -25,18 +25,18 @@ require (
 	github.com/spf13/viper v1.7.0
 	github.com/stretchr/testify v1.7.0
 	github.com/tmc/grpc-websocket-proxy v0.0.0-20190109142713-0ad062ec5ee5
-	go.opencensus.io v0.22.3
+	go.opencensus.io v0.23.0


(non-blocking) I wonder why opencensus incremented? Although it doesn't likely matter.

🤷

It looks like the v0.23.0 was released in Feb 2021 and has a few bug fixes relative to v0.22.3 (including a memory leak).

markmandel · 2022-08-24T21:28:22Z

go.mod

-	google.golang.org/grpc v1.27.1
+	golang.org/x/tools v0.1.5
+	google.golang.org/genproto v0.0.0-20210402141018-6c239bbf2bb1
+	google.golang.org/grpc v1.36.1


Just noting that if we are upgrading grpc, we will likely also want to regen all the clients at some point before the next release. Doesn't have to be in this PR, as long as it's noted in #2642

Good point. I can tackle that in a follow up PR.

markmandel · 2022-08-24T21:29:58Z

install/helm/agones/templates/crds/k8s/_io.k8s.api.core.v1.PodTemplateSpec.yaml

@@ -200,7 +200,9 @@ properties:
                                description: The label key that the selector applies to.
                                type: string
                              operator:
-                                description: Represents a key's relationship to a set of values. Valid operators are In, NotIn, Exists, DoesNotExist. Gt, and Lt.
+                                description: |+


I love that this hacky bash script is still working.

google-oss-prow · 2022-08-24T21:33:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

markmandel · 2022-08-24T21:34:34Z

Approved.

Will let you decide when you want to manage regenerating the grpc clients for the SDKs (now or later).

roberthbailey · 2022-08-24T22:13:08Z

Will let you decide when you want to manage regenerating the grpc clients for the SDKs (now or later).

Definitely later. This PR already has enough commits. ;)

roberthbailey added the kind/breaking Breaking change label Aug 17, 2022

google-oss-prow bot added the size/XXL label Aug 17, 2022

google-oss-prow bot requested review from EricFortin and markmandel August 17, 2022 06:28

google-oss-prow bot added the approved label Aug 17, 2022

roberthbailey assigned pooneh-m Aug 17, 2022

roberthbailey force-pushed the k8s-1.23 branch from d0a8af5 to c6e8911 Compare August 22, 2022 20:54

roberthbailey assigned markmandel and unassigned pooneh-m Aug 22, 2022

roberthbailey added 8 commits August 24, 2022 15:58

Upgrade terraform to Kubernetes 1.23.

2f5b8fb

Upgrade kubectl to 1.23 in dev tooling.

36c812f

Update the dev version of Kubernetes in the website to 1.23.

52d14b9

Update Minikube and Kind dev tooling to Kubernetes 1.23.

4182c51

Upgrade client-go to v0.23.9.

3d2b66c

$ go get k8s.io/client-go@v0.23.9 $ go mod tidy $ go mod vendor

Fix compile errors from updating client-go.

e06a08c

Updated crd-doc-config.json and ran make gen-api-docs followed

7b30ec3

by `make gen-crd-client`.

Regenerate Kubernetes resource includes (ObjectMeta, PodTemplateSpec)

75177f7

for Kubernetes 1.23.

roberthbailey force-pushed the k8s-1.23 branch from c6e8911 to 75177f7 Compare August 24, 2022 15:58

markmandel approved these changes Aug 24, 2022

View reviewed changes

google-oss-prow bot added the lgtm label Aug 24, 2022

roberthbailey merged commit 2a6a033 into googleforgames:main Aug 24, 2022

roberthbailey mentioned this pull request Aug 24, 2022

Update Kubernetes to 1.23 #2642

Closed

25 tasks

SaitejaTamma added this to the 1.26.0 milestone Sep 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Agones to Kubernetes 1.23 #2711

Upgrade Agones to Kubernetes 1.23 #2711

roberthbailey commented Aug 17, 2022

agones-bot commented Aug 17, 2022

agones-bot commented Aug 22, 2022

roberthbailey commented Aug 22, 2022

agones-bot commented Aug 22, 2022

agones-bot commented Aug 24, 2022

markmandel Aug 24, 2022

roberthbailey Aug 24, 2022

markmandel Aug 24, 2022

roberthbailey Aug 24, 2022

markmandel Aug 24, 2022

roberthbailey Aug 24, 2022

google-oss-prow bot commented Aug 24, 2022

markmandel commented Aug 24, 2022

roberthbailey commented Aug 24, 2022

Upgrade Agones to Kubernetes 1.23 #2711

Upgrade Agones to Kubernetes 1.23 #2711

Conversation

roberthbailey commented Aug 17, 2022

agones-bot commented Aug 17, 2022

agones-bot commented Aug 22, 2022

roberthbailey commented Aug 22, 2022

agones-bot commented Aug 22, 2022

agones-bot commented Aug 24, 2022

markmandel Aug 24, 2022

Choose a reason for hiding this comment

roberthbailey Aug 24, 2022

Choose a reason for hiding this comment

markmandel Aug 24, 2022

Choose a reason for hiding this comment

roberthbailey Aug 24, 2022

Choose a reason for hiding this comment

markmandel Aug 24, 2022

Choose a reason for hiding this comment

roberthbailey Aug 24, 2022

Choose a reason for hiding this comment

google-oss-prow bot commented Aug 24, 2022

markmandel commented Aug 24, 2022

roberthbailey commented Aug 24, 2022