Generate Changelog - Release Automation: Add cloud build target for release builds #2884

mangalpalli · 2023-01-03T15:50:59Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Created a Make target in release.mk that manually submits a cloud build job
The cloud build job generates the CHANGELOG file for both RC and release.
The file is stored in a Google Cloud storage bucket so that we can retrieve it to be added to our PR for later.

Which issue(s) this PR fixes:

Closes #2460

Special notes for your reviewer:

NA

…e target

agones-bot · 2023-01-03T16:24:57Z

Build Failed 😱

Build Id: d668c2ce-b66a-4690-9278-9b48d2fea498

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-01-03T16:26:24Z

Build Succeeded 👏

Build Id: 990899b7-0e99-41d5-95a7-229af18a551e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-b07ae49-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-b07ae49-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-b07ae49-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-b07ae49-amd64
Linux C++ SDK (build): agonessdk-1.29.0-b07ae49-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-b07ae49-amd64.zip

A preview of the website (the last 30 builds are retained):

https://b07ae49-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2884/head:pr_2884 && git checkout pr_2884
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-b07ae49-amd64

agones-bot · 2023-01-03T16:40:46Z

Build Succeeded 👏

Build Id: f5c1d49b-7382-4b99-bdb7-f00d147c670e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-7e60d8d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-7e60d8d-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-7e60d8d-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-7e60d8d-amd64
Linux C++ SDK (build): agonessdk-1.29.0-7e60d8d-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-7e60d8d-amd64.zip

A preview of the website (the last 30 builds are retained):

https://7e60d8d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2884/head:pr_2884 && git checkout pr_2884
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-7e60d8d-amd64

markmandel

I'll take this for a run to test - but at first glance, this looks great!

markmandel · 2023-01-04T02:24:11Z

docs/governance/templates/release_issue.md

@@ -34,8 +34,8 @@ and copy it into a release issue. Fill in relevant values, found inside {}
 - [ ] `git checkout main && git pull --rebase upstream main`
 - [ ] If full release, run `make site-deploy SERVICE={version}-1`, (replace . with -)
    - For example, if you are creating the 1.18.0 release, then you would deploy the 1-17-0 service (release minus one, and then replace dots with dashes).
- [ ] Run `make gen-changelog` to generate the CHANGELOG.md (if release candidate
-  `make gen-changelog RELEASE_VERSION={version}-rc`). You will need your
+- [ ] Run `make build-release` to generate the CHANGELOG.md (if release candidate


We should also add a note about grabbing the CHANGELOG from the GCS bucket and putting it locally.

If you like

https://github.com/googleforgames/quilkin/blob/192376f579b3d0ee9001a25feb2ce7a1791364de/build/templates/release-issue.md?plain=1#L20-L21

You could steal that.

This seems like the wrong order 😄 you've got notes to download the artifacts before you run the make build-release 😁

Just gently bumping this change - only thing blocking this PR.

Fixed it. :)

agones-bot · 2023-01-05T16:22:49Z

Build Failed 😱

Build Id: 6e06d42d-908f-4bad-b3bd-1c40e191edc2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-01-05T16:45:22Z

Build Succeeded 👏

Build Id: b36a2635-8c85-43da-9829-c8eaaf1067cc

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-36d4135-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-36d4135-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-36d4135-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-36d4135-amd64
Linux C++ SDK (build): agonessdk-1.29.0-36d4135-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-36d4135-amd64.zip

A preview of the website (the last 30 builds are retained):

https://36d4135-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2884/head:pr_2884 && git checkout pr_2884
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-36d4135-amd64

markmandel · 2023-01-07T01:22:16Z

Just set this up and ran this locally - had to make some permission changes / setup the secret, but all worked 👍🏻

agones-bot · 2023-01-09T18:45:15Z

Build Succeeded 👏

Build Id: d37115e5-ab9f-456a-9b16-62b6a57de8ff

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-d13e616-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-d13e616-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-d13e616-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-d13e616-amd64
Linux C++ SDK (build): agonessdk-1.29.0-d13e616-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-d13e616-amd64.zip

A preview of the website (the last 30 builds are retained):

https://d13e616-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2884/head:pr_2884 && git checkout pr_2884
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-d13e616-amd64

google-oss-prow · 2023-01-10T16:04:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangalpalli, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-01-10T16:27:22Z

Build Succeeded 👏

Build Id: 0c5f9a8e-a45e-44ee-81fe-87d693f6787f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.29.0-7e1438c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.29.0-7e1438c-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.29.0-7e1438c-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.29.0-7e1438c-amd64
Linux C++ SDK (build): agonessdk-1.29.0-7e1438c-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.29.0-7e1438c-amd64.zip

A preview of the website (the last 30 builds are retained):

https://7e1438c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2884/head:pr_2884 && git checkout pr_2884
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-7e1438c-amd64

…elease builds (googleforgames#2884) * Release target for cloud build job * Added Cloudbuild File * changing env variables * changelog gen changes * Handling CHANGELOG generation for both the release and RC * Updating release document to incorporate new CHANGELOG generation make target * Removed testing changes * Updated release doc * review changes

mangalpalli and others added 7 commits November 21, 2022 14:10

Release target for cloud build job

49271c9

Added Cloudbuild File

cb8a56f

changing env variables

2a7f4c1

Merge branch 'googleforgames:main' into issue-2460

f6e2cdf

changelog gen changes

7d9923a

Handling CHANGELOG generation for both the release and RC

bcf93da

Updating release document to incorporate new CHANGELOG generation mak…

b07ae49

…e target

google-oss-prow bot added the do-not-merge/work-in-progress label Jan 3, 2023

google-oss-prow bot requested review from markmandel and pooneh-m January 3, 2023 15:51

google-oss-prow bot added the size/M label Jan 3, 2023

mangalpalli added this to the 1.29.0 milestone Jan 3, 2023

mangalpalli self-assigned this Jan 3, 2023

mangalpalli added the kind/feature New features for Agones label Jan 3, 2023

mangalpalli marked this pull request as ready for review January 3, 2023 15:56

google-oss-prow bot requested a review from dzlier-gcp January 3, 2023 15:56

Removed testing changes

50c5c08

mangalpalli force-pushed the issue-2460 branch from 7e60d8d to 50c5c08 Compare January 3, 2023 16:01

mangalpalli removed the do-not-merge/work-in-progress label Jan 3, 2023

mangalpalli changed the title ~~Issue 2460~~ Generate Changelog - Release Automation: Add cloud build target for release builds Jan 3, 2023

markmandel reviewed Jan 4, 2023

View reviewed changes

mangalpalli and others added 2 commits January 5, 2023 10:11

Merge branch 'main' into issue-2460

0543510

Updated release doc

36d4135

roberthbailey assigned markmandel and unassigned mangalpalli Jan 6, 2023

Merge branch 'googleforgames:main' into issue-2460

d13e616

review changes

7e1438c

markmandel approved these changes Jan 10, 2023

View reviewed changes

google-oss-prow bot added the lgtm label Jan 10, 2023

google-oss-prow bot added the approved label Jan 10, 2023

markmandel enabled auto-merge (squash) January 10, 2023 16:05

markmandel merged commit 52889ee into googleforgames:main Jan 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate Changelog - Release Automation: Add cloud build target for release builds #2884

Generate Changelog - Release Automation: Add cloud build target for release builds #2884

mangalpalli commented Jan 3, 2023

agones-bot commented Jan 3, 2023

agones-bot commented Jan 3, 2023

agones-bot commented Jan 3, 2023

markmandel left a comment

markmandel Jan 4, 2023

mangalpalli Jan 5, 2023

markmandel Jan 5, 2023

markmandel Jan 9, 2023

mangalpalli Jan 10, 2023

agones-bot commented Jan 5, 2023

agones-bot commented Jan 5, 2023

markmandel commented Jan 7, 2023

agones-bot commented Jan 9, 2023

google-oss-prow bot commented Jan 10, 2023

agones-bot commented Jan 10, 2023

Generate Changelog - Release Automation: Add cloud build target for release builds #2884

Generate Changelog - Release Automation: Add cloud build target for release builds #2884

Conversation

mangalpalli commented Jan 3, 2023

agones-bot commented Jan 3, 2023

agones-bot commented Jan 3, 2023

agones-bot commented Jan 3, 2023

markmandel left a comment

Choose a reason for hiding this comment

markmandel Jan 4, 2023

Choose a reason for hiding this comment

mangalpalli Jan 5, 2023

Choose a reason for hiding this comment

markmandel Jan 5, 2023

Choose a reason for hiding this comment

markmandel Jan 9, 2023

Choose a reason for hiding this comment

mangalpalli Jan 10, 2023

Choose a reason for hiding this comment

agones-bot commented Jan 5, 2023

agones-bot commented Jan 5, 2023

markmandel commented Jan 7, 2023

agones-bot commented Jan 9, 2023

google-oss-prow bot commented Jan 10, 2023

agones-bot commented Jan 10, 2023