-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GKE Autopilot: Add terraform module, users #2912
GKE Autopilot: Add terraform module, users #2912
Conversation
c793e1e
to
118f0c0
Compare
Build Succeeded 👏 Build Id: d8c16d28-3421-49a7-ad9b-02128c7df41f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😱 Build Id: 8b701bba-2f81-45c5-8fc9-dbc45975ce49 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: f58333cb-3194-457e-9e78-0f2af2602d8c To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
118f0c0
to
e164cac
Compare
Build Succeeded 👏 Build Id: cc3f0dcf-1fed-4f58-838b-8ca704635b15 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
e164cac
to
6687cc8
Compare
Build Failed 😱 Build Id: e1ec9e15-d463-4462-a611-58cdd7efbeef To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 9159120c-d51b-4701-81a4-36e3b78dff0a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
6687cc8
to
6082b85
Compare
Build Succeeded 👏 Build Id: 4496f833-3984-41ef-a5af-9ab869b4ea04 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
6082b85
to
413dfe7
Compare
Build Succeeded 👏 Build Id: 088caa80-6227-48ea-a099-77d5ba6e8676 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
// Run: | ||
// terraform apply -var project="<YOUR_GCP_ProjectID>" [-var agones_version="1.30.0"] | ||
|
||
terraform { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to have a following up PR to include the instruction about the usage or this Module? I assume that will be something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - it's going out in a broader set of doc updates when we work out how we want to structure it.
413dfe7
to
58ca443
Compare
Build Failed 😱 Build Id: 76ce772b-0a3b-4e4a-8e2a-b5780ab88da8 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
58ca443
to
b50e320
Compare
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: 8c7bfb9d-51e8-4579-a3fb-4bbfa6087aa0 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 01b25724-538a-4a47-80a3-7e0beecd4db1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
… for multi-cluster * Adds install/terraform/modules/gke-autopilot module, based on modules/gke * Adds example module (will document) * Refactors e2es, based on discussions with @gongmax: now the top-level e2e module is the "project" module for the whole e2e project, with additional gke-autopilot and gke-standard modules underneath as "per-cluster" modules. * Allows firewall creation to be handled in project module.
b50e320
to
2bfdf14
Compare
Build Succeeded 👏 Build Id: a6f9bfdb-cb4e-47ee-9fa5-358b8a531b8d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
* GKE Terraform: Add Autopilot terraform module, refactor e2e terraform for multi-cluster * Adds install/terraform/modules/gke-autopilot module, based on modules/gke * Adds example module (will document) * Refactors e2es, based on discussions with @gongmax: now the top-level e2e module is the "project" module for the whole e2e project, with additional gke-autopilot and gke-standard modules underneath as "per-cluster" modules. * Allows firewall creation to be handled in project module.
This adds an install/terraform module names
gke-autopilot
, example terraform submodule, build submodule, e2e submodule and e2e Makefile targets for GKE Autopilot.I did not add additional Makefile targets - we can do those as needed, but there do seem to be a group of other targets that use the
gke
module.Towards #2777