-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error callback to testSDKClient #2964
Add error callback to testSDKClient #2964
Conversation
/cc zmerlynn |
Build Failed 😱 Build Id: 0e9c2fb9-eab4-4fb0-83d6-65542e703bef To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
I was recreating the test clusters which made the CI fail. I will retry this build after the test clusters are created. |
Build Failed 😱 Build Id: 0ea987ef-f0ea-4328-b60c-1ab4b19a58b3 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: c407c6a3-b2d6-431b-b2a8-e34f42c31a35 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: ce2cd3fa-cd01-45d6-97e0-9609dde4dc89 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 271463e5-c97f-4797-aaca-da96a70420c9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
I greatly appreciate any help reproducing this @gongmax. I don't how to reproduce the error and as on Windows I'm not sure if possible to reproduce the error e.g. not all the Make scripts work for me 100% of the time |
@steven-supersolid can you rebase against main and push please? Because you are on an org fork, we can't update on our end. (automerge is enabled, so you should only have to do this once). |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aimuz, roberthbailey, steven-supersolid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 9b2cea1a-2873-41e0-8eb4-64077706b7b2 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Adds an error callback to
watchGameServer
so that errors can be caught during watchingWhich issue(s) this PR fixes:
Closes #2954
Special notes for your reviewer: