CRDs for AllocationOverflow #2979

markmandel · 2023-02-16T22:59:56Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Implementation of yaml and backing Go code for the CRDs for supporting Fleet Allocation Overflow tracking.

Which issue(s) this PR fixes:

Work on #2682

Special notes for your reviewer:

Next will be controller code and e2e tests, docs are also incoming.

agones-bot · 2023-02-16T23:49:37Z

Build Succeeded 👏

Build Id: 32f7a1dd-6fed-408b-944c-d3f24edccd72

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-eca02c4-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-eca02c4-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-eca02c4-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-eca02c4-amd64
Linux C++ SDK (build): agonessdk-1.30.0-eca02c4-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-eca02c4-amd64.zip

A preview of the website (the last 30 builds are retained):

https://eca02c4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2979/head:pr_2979 && git checkout pr_2979
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-eca02c4-amd64

agones-bot · 2023-02-17T06:48:48Z

Build Succeeded 👏

Build Id: 653110de-b8f7-4f7f-8dbe-4af61da5f080

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-d492257-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-d492257-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-d492257-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-d492257-amd64
Linux C++ SDK (build): agonessdk-1.30.0-d492257-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-d492257-amd64.zip

A preview of the website (the last 30 builds are retained):

https://d492257-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2979/head:pr_2979 && git checkout pr_2979
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-d492257-amd64

gongmax

LGTM

google-oss-prow · 2023-02-17T19:43:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-02-17T19:46:11Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-02-17T20:36:54Z

Build Succeeded 👏

Build Id: 8d85308b-5afc-4a21-ac77-83faf9c767cc

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-87ce7f7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-87ce7f7-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-87ce7f7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-87ce7f7-amd64
Linux C++ SDK (build): agonessdk-1.30.0-87ce7f7-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-87ce7f7-amd64.zip

A preview of the website (the last 30 builds are retained):

https://87ce7f7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2979/head:pr_2979 && git checkout pr_2979
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-87ce7f7-amd64

aimuz · 2023-02-22T13:16:44Z

pkg/apis/agones/v1/common_test.go

@@ -0,0 +1,208 @@
+// Copyright 2022 Google LLC All Rights Reserved.


Good catch!

Implementation of yaml and backing Go code for the CRDs for supporting Fleet Allocation Overflow tracking. Work on googleforgames#2682

agones-bot · 2023-02-23T01:13:57Z

Build Failed 😱

Build Id: 231d6d80-b566-4cb8-8534-13859a8d0df4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-02-23T01:17:28Z

@chiayi this mean anything to you? Saw this flake in my e2e tests.

neric-1.24: Step #1 - "e2e-feature-gates": --- FAIL: TestGameServerHealthyAfterDeletingPodWhileOneExtensionsDown (0.15s)
generic-1.24: Step #1 - "e2e-feature-gates": panic: runtime error: invalid memory address or nil pointer dereference [recovered]
generic-1.24: Step #1 - "e2e-feature-gates": 	panic: runtime error: invalid memory address or nil pointer dereference
generic-1.24: Step #1 - "e2e-feature-gates": [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x20f9f70]
generic-1.24: Step #1 - "e2e-feature-gates": 
generic-1.24: Step #1 - "e2e-feature-gates": goroutine 9 [running]:
generic-1.24: Step #1 - "e2e-feature-gates": testing.tRunner.func1.2({0x22a4200, 0x340b020})
generic-1.24: Step #1 - "e2e-feature-gates": 	/usr/local/go/src/testing/testing.go:1396 +0x372
generic-1.24: Step #1 - "e2e-feature-gates": testing.tRunner.func1()
generic-1.24: Step #1 - "e2e-feature-gates": 	/usr/local/go/src/testing/testing.go:1399 +0x5f0
generic-1.24: Step #1 - "e2e-feature-gates": panic({0x22a4200, 0x340b020})
generic-1.24: Step #1 - "e2e-feature-gates": 	/usr/local/go/src/runtime/panic.go:890 +0x262
generic-1.24: Step #1 - "e2e-feature-gates": agones.dev/agones/test/e2e/extensions.TestGameServerHealthyAfterDeletingPodWhileOneExtensionsDown(0xc0002f6d00)
generic-1.24: Step #1 - "e2e-feature-gates": 	/go/src/agones.dev/agones/test/e2e/extensions/high_availability_test.go:56 +0x490
generic-1.24: Step #1 - "e2e-feature-gates": testing.tRunner(0xc0002f6d00, 0x258d3f0)
generic-1.24: Step #1 - "e2e-feature-gates": 	/usr/local/go/src/testing/testing.go:1446 +0x217
generic-1.24: Step #1 - "e2e-feature-gates": created by testing.(*T).Run
generic-1.24: Step #1 - "e2e-feature-gates": 	/usr/local/go/src/testing/testing.go:1493 +0x75e
generic-1.24: Step #1 - "e2e-feature-gates": FAIL test/e2e/extensions.TestGameServerHealthyAfterDeletingPodWhileOneExtensionsDown (0.15s)
generic-1.24: Step #1 - "e2e-feature-gates": FAIL test/e2e/extensions

agones-bot · 2023-02-23T02:58:40Z

Build Failed 😱

Build Id: 738167e8-7a3d-4b89-8178-8e53dcd1a0c8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-02-23T16:58:10Z

Spent an hour and 30 minutes waiting to be leader.

e2e-wait-to-become-leader- | 01:30:00-- | --

@zmerlynn seeing this a bit these days? Just too many builds?

agones-bot · 2023-02-23T20:10:31Z

Build Failed 😱

Build Id: df712de7-ec56-4d20-8fef-7bcc7b28ee23

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-02-23T20:30:49Z

Got this flake again:

gke-autopilot-1.25: Step #1 - "e2e-feature-gates": time="2023-02-23 20:09:58.528" level=info msg="Removing one of the Extensions Pods" test=TestGameServerHealthyAfterDeletingPodWhileOneExtensionsDown
gke-autopilot-1.25: Step #1 - "e2e-feature-gates": time="2023-02-23 20:09:58.605" level=info msg="Creating default game server" test=TestGameServerHealthyAfterDeletingPodWhileOneExtensionsDown
gke-autopilot-1.25: Step #1 - "e2e-feature-gates":     high_availability_test.go:55: 
gke-autopilot-1.25: Step #1 - "e2e-feature-gates":         	Error Trace:	/go/src/agones.dev/agones/test/e2e/extensions/high_availability_test.go:55
gke-autopilot-1.25: Step #1 - "e2e-feature-gates":         	Error:      	Received unexpected error:
gke-autopilot-1.25: Step #1 - "e2e-feature-gates":         	            	creating {game-server [{udp-port Dynamic <nil> 7654 0 UDP}] {false 0 0 0}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] []  []} {[] [] [{game-server us-docker.pkg.dev/agones-images/examples/simple-game-server:0.14 [] []  [] [] [] {map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}] map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}]} [] [] nil nil nil nil   IfNotPresent nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil> nil}} <nil> map[] map[] <nil>} GameServer instances failed (): Internal error occurred: failed calling webhook "mutations.agones.dev": failed to call webhook: Post "https://agones-controller-service.agones-system.svc:443/mutate?timeout=10s": dial tcp 10.12.1.118:8081: connect: connection refused
gke-autopilot-1.25: Step #1 - "e2e-feature-gates":         	Test:       	TestGameServerHealthyAfterDeletingPodWhileOneExtensionsDown
gke-autopilot-1.25: Step #1 - "e2e-feature-gates":         	Messages:   	Could not get a GameServer ready
gke-autopilot-1.25: Step #1 - "e2e-feature-gates": --- FAIL: TestGameServerHealthyAfterDeletingPodWhileOneExtensionsDown (0.18s)
gke-autopilot-1.25: Step #1 - "e2e-feature-gates": panic: runtime error: invalid memory address or nil pointer dereference [recovered]
gke-autopilot-1.25: Step #1 - "e2e-feature-gates": 	panic: runtime error: invalid memory address or nil pointer dereference
gke-autopilot-1.25: Step #1 - "e2e-feature-gates": [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x20fa2b0]
gke-autopilot-1.25: Step #1 - "e2e-feature-gates":

agones-bot · 2023-02-23T22:26:02Z

Build Failed 😱

Build Id: 70eeda4f-9044-46af-a010-552b40a46774

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-24T05:41:12Z

Build Succeeded 👏

Build Id: bf614795-0689-4df4-9d44-727440dcf379

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-6af79ae-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-6af79ae-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-6af79ae-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-6af79ae-amd64
Linux C++ SDK (build): agonessdk-1.30.0-6af79ae-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-6af79ae-amd64.zip

A preview of the website (the last 30 builds are retained):

https://6af79ae-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2979/head:pr_2979 && git checkout pr_2979
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-6af79ae-amd64

markmandel requested review from roberthbailey and gongmax February 16, 2023 22:59

google-oss-prow bot requested a review from EricFortin February 16, 2023 23:00

google-oss-prow bot added approved size/XL labels Feb 16, 2023

gongmax approved these changes Feb 17, 2023

View reviewed changes

google-oss-prow bot assigned gongmax Feb 17, 2023

google-oss-prow bot added the lgtm label Feb 17, 2023

google-oss-prow bot removed the lgtm label Feb 17, 2023

aimuz reviewed Feb 22, 2023

View reviewed changes

CRDs for AllocationOverflow

f214b8b

Implementation of yaml and backing Go code for the CRDs for supporting Fleet Allocation Overflow tracking. Work on googleforgames#2682

markmandel force-pushed the overflow/crds branch from 87ce7f7 to f214b8b Compare February 22, 2023 23:43

markmandel added the kind/feature New features for Agones label Feb 23, 2023

markmandel enabled auto-merge (squash) February 23, 2023 17:16

zmerlynn mentioned this pull request Feb 23, 2023

SIGSEGV flake in TestGameServerHealthyAfterDeletingPodWhileOneExtensionsDown #2992

Closed

Merge branch 'main' into overflow/crds

cff589f

Merge branch 'main' into overflow/crds

6af79ae

markmandel merged commit 2bdb487 into googleforgames:main Feb 24, 2023

markmandel deleted the overflow/crds branch February 24, 2023 05:41

Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CRDs for AllocationOverflow #2979

CRDs for AllocationOverflow #2979

markmandel commented Feb 16, 2023

agones-bot commented Feb 16, 2023

agones-bot commented Feb 17, 2023

gongmax left a comment

google-oss-prow bot commented Feb 17, 2023

google-oss-prow bot commented Feb 17, 2023

agones-bot commented Feb 17, 2023

aimuz Feb 22, 2023

markmandel Feb 22, 2023

markmandel Feb 22, 2023

agones-bot commented Feb 23, 2023

markmandel commented Feb 23, 2023

agones-bot commented Feb 23, 2023

markmandel commented Feb 23, 2023

agones-bot commented Feb 23, 2023

markmandel commented Feb 23, 2023

agones-bot commented Feb 23, 2023

agones-bot commented Feb 24, 2023

		@@ -0,0 +1,208 @@
		// Copyright 2022 Google LLC All Rights Reserved.

CRDs for AllocationOverflow #2979

CRDs for AllocationOverflow #2979

Conversation

markmandel commented Feb 16, 2023

agones-bot commented Feb 16, 2023

agones-bot commented Feb 17, 2023

gongmax left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Feb 17, 2023

google-oss-prow bot commented Feb 17, 2023

agones-bot commented Feb 17, 2023

aimuz Feb 22, 2023

Choose a reason for hiding this comment

markmandel Feb 22, 2023

Choose a reason for hiding this comment

markmandel Feb 22, 2023

Choose a reason for hiding this comment

agones-bot commented Feb 23, 2023

markmandel commented Feb 23, 2023

agones-bot commented Feb 23, 2023

markmandel commented Feb 23, 2023

agones-bot commented Feb 23, 2023

markmandel commented Feb 23, 2023

agones-bot commented Feb 23, 2023

agones-bot commented Feb 24, 2023