Adds default values for Counters and Lists fields #2983

igooch · 2023-02-21T21:51:43Z

What type of PR is this?
/kind feature

What this PR does / Why we need it:
Adds default values for Counters and Lists fields.
Populates initial GamerServerStatus for Counters and Lists from the GameServerSpec.
Removes remaining references to featureGates in CRDs (these fields are validated in the validate function).

Which issue(s) this PR fixes:
Working on #2716

Special notes for your reviewer:

agones-bot · 2023-02-21T21:58:09Z

Build Failed 😱

Build Id: 14932a2a-bc27-41d4-9d74-13065881caf2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-21T22:08:29Z

Build Failed 😱

Build Id: ae7acbf5-ffd2-4af5-9fc5-d92617e0d9c6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-21T22:37:32Z

Build Failed 😱

Build Id: 49452c21-942b-4ac7-a694-ef3a23bd537d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-22T08:10:45Z

Build Succeeded 👏

Build Id: 56a26205-8ed2-47ab-8fae-3037847e9cd1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-a547aba-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-a547aba-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-a547aba-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-a547aba-amd64
Linux C++ SDK (build): agonessdk-1.30.0-a547aba-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-a547aba-amd64.zip

A preview of the website (the last 30 builds are retained):

https://a547aba-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2983/head:pr_2983 && git checkout pr_2983
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-a547aba-amd64

agones-bot · 2023-02-22T22:50:07Z

Build Failed 😱

Build Id: 85eebc7f-372d-45d1-94e8-3a382918aae6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-23T00:18:31Z

Build Succeeded 👏

Build Id: 67b0af3c-a5d7-4d09-9cbc-4f1b900b8a08

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-350176a-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-350176a-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-350176a-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-350176a-amd64
Linux C++ SDK (build): agonessdk-1.30.0-350176a-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-350176a-amd64.zip

A preview of the website (the last 30 builds are retained):

https://350176a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2983/head:pr_2983 && git checkout pr_2983
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-350176a-amd64

agones-bot · 2023-02-23T00:55:33Z

Build Succeeded 👏

Build Id: d661db47-d229-4369-99fc-ece1f460f0cc

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-b881ee3-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-b881ee3-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-b881ee3-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-b881ee3-amd64
Linux C++ SDK (build): agonessdk-1.30.0-b881ee3-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-b881ee3-amd64.zip

A preview of the website (the last 30 builds are retained):

https://b881ee3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2983/head:pr_2983 && git checkout pr_2983
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-b881ee3-amd64

gongmax

LGTM

agones-bot · 2023-02-23T05:34:10Z

Build Succeeded 👏

Build Id: 25539f75-d78f-480e-8de2-0f3521841cb8

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-142c097-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-142c097-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-142c097-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-142c097-amd64
Linux C++ SDK (build): agonessdk-1.30.0-142c097-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-142c097-amd64.zip

A preview of the website (the last 30 builds are retained):

https://142c097-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2983/head:pr_2983 && git checkout pr_2983
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-142c097-amd64

pkg/apis/agones/v1/gameserver.go

markmandel · 2023-02-23T18:40:31Z

pkg/apis/agones/v1/gameserver.go

@@ -311,6 +304,18 @@ type PlayerStatus struct {
 	IDs      []string `json:"ids"`
 }

+// CounterStatus stores the current counter values
+type CounterStatus struct {


Since it's used in both Spec and Status, maybe the names should be Counter and List ? WDYT?

markmandel

Just marking as request changes, since I'd like to get my comments reviewed before merging.

agones-bot · 2023-02-24T00:03:05Z

Build Failed 😱

Build Id: d2d98834-d3ff-48bd-9f2b-347d5cb9b778

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-prow · 2023-02-24T01:57:12Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-02-24T03:36:26Z

Build Failed 😱

Build Id: c61a5a8d-e4c6-4433-b81f-624d23ba907d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-24T17:33:35Z

Build Succeeded 👏

Build Id: ba73c3f8-e58c-4423-af93-8933496d558e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-8d39214-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-8d39214-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-8d39214-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-8d39214-amd64
Linux C++ SDK (build): agonessdk-1.30.0-8d39214-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-8d39214-amd64.zip

A preview of the website (the last 30 builds are retained):

https://8d39214-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2983/head:pr_2983 && git checkout pr_2983
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-8d39214-amd64

markmandel · 2023-02-24T19:25:14Z

Ruh roh. Lots of conflicts. Sorry - that was my CRD work.

agones-bot · 2023-02-25T02:32:06Z

Build Failed 😱

Build Id: 020b8349-51b1-4ea2-9b6e-af789a6fc23f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

GamerServerStatus for Counters and Lists from the GameServerSpec

agones-bot · 2023-02-27T00:42:30Z

Build Failed 😱

Build Id: 7d7e4f61-5ce6-466f-a83d-957d2c2b204e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-27T02:02:43Z

Build Failed 😱

Build Id: 9d2d22b4-3b7e-4dc5-bf9e-0e19a5bfe442

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-02-27T07:18:14Z

Build Failed 😱

Build Id: 1255b437-c03e-4609-8c0d-1927378a4078

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

feature gates in the CRDs.

agones-bot · 2023-02-27T18:26:06Z

Build Succeeded 👏

Build Id: 5ef69e69-d4e4-4176-8416-913b2b0438ea

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.30.0-709b1cd-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.30.0-709b1cd-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.30.0-709b1cd-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.30.0-709b1cd-amd64
Linux C++ SDK (build): agonessdk-1.30.0-709b1cd-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.30.0-709b1cd-amd64.zip

A preview of the website (the last 30 builds are retained):

https://709b1cd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2983/head:pr_2983 && git checkout pr_2983
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-709b1cd-amd64

google-oss-prow bot added the size/XXL label Feb 21, 2023

google-oss-prow bot requested review from aLekSer and markmandel February 21, 2023 21:52

igooch force-pushed the arbitrary-counts-lists-2716 branch from 08bc9ca to f1120ff Compare February 21, 2023 22:02

google-oss-prow bot added size/L and removed size/XXL labels Feb 21, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from f1120ff to a547aba Compare February 21, 2023 22:09

igooch changed the title ~~Arbitrary counts lists 2716~~ Arbitrary counts lists 2716/Defaults Feb 22, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 350176a to 3db7aae Compare February 22, 2023 22:40

igooch force-pushed the arbitrary-counts-lists-2716 branch from 3db7aae to b881ee3 Compare February 22, 2023 23:10

google-oss-prow bot added size/XXL and removed size/L labels Feb 22, 2023

markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Feb 23, 2023

gongmax approved these changes Feb 23, 2023

View reviewed changes

google-oss-prow bot assigned gongmax Feb 23, 2023

google-oss-prow bot added lgtm and removed lgtm labels Feb 23, 2023

markmandel reviewed Feb 23, 2023

View reviewed changes

markmandel requested changes Feb 23, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Feb 23, 2023

google-oss-prow bot added the approved label Feb 23, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from 392ac06 to 8d39214 Compare February 24, 2023 01:57

google-oss-prow bot removed the lgtm label Feb 24, 2023

google-oss-prow bot added size/XXL and removed size/L labels Feb 24, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from 8d39214 to 473afb7 Compare February 25, 2023 02:25

igooch added 2 commits February 27, 2023 00:35

Adds defaults for Counters and Lists and populates

ded8023

GamerServerStatus for Counters and Lists from the GameServerSpec

Updates applyCountsListsStatus to copy only Counter or Lists

0096dcb

igooch force-pushed the arbitrary-counts-lists-2716 branch from 473afb7 to 0096dcb Compare February 27, 2023 00:35

google-oss-prow bot added size/L and removed size/XXL labels Feb 27, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch 3 times, most recently from b7188ef to fde7181 Compare February 27, 2023 17:21

cleaning up after messy rebase and removing remaing references to

709b1cd

feature gates in the CRDs.

igooch force-pushed the arbitrary-counts-lists-2716 branch from fde7181 to 709b1cd Compare February 27, 2023 17:34

igooch changed the title ~~Arbitrary counts lists 2716/Defaults~~ Adds default values for Counters and Lists fields Feb 27, 2023

gongmax merged commit e0f53f8 into googleforgames:main Feb 27, 2023

Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023

igooch mentioned this pull request Jan 18, 2024

Request for igooch to become Approver #3600

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds default values for Counters and Lists fields #2983

Adds default values for Counters and Lists fields #2983

igooch commented Feb 21, 2023 •

edited

Loading

agones-bot commented Feb 21, 2023

agones-bot commented Feb 21, 2023

agones-bot commented Feb 21, 2023

agones-bot commented Feb 22, 2023

agones-bot commented Feb 22, 2023

agones-bot commented Feb 23, 2023

agones-bot commented Feb 23, 2023

gongmax left a comment

agones-bot commented Feb 23, 2023

markmandel Feb 23, 2023

markmandel left a comment

agones-bot commented Feb 24, 2023

google-oss-prow bot commented Feb 24, 2023

agones-bot commented Feb 24, 2023

agones-bot commented Feb 24, 2023

markmandel commented Feb 24, 2023

agones-bot commented Feb 25, 2023

agones-bot commented Feb 27, 2023

agones-bot commented Feb 27, 2023

agones-bot commented Feb 27, 2023

agones-bot commented Feb 27, 2023

Adds default values for Counters and Lists fields #2983

Adds default values for Counters and Lists fields #2983

Conversation

igooch commented Feb 21, 2023 • edited Loading

agones-bot commented Feb 21, 2023

agones-bot commented Feb 21, 2023

agones-bot commented Feb 21, 2023

agones-bot commented Feb 22, 2023

agones-bot commented Feb 22, 2023

agones-bot commented Feb 23, 2023

agones-bot commented Feb 23, 2023

gongmax left a comment

Choose a reason for hiding this comment

agones-bot commented Feb 23, 2023

markmandel Feb 23, 2023

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Feb 24, 2023

google-oss-prow bot commented Feb 24, 2023

agones-bot commented Feb 24, 2023

agones-bot commented Feb 24, 2023

markmandel commented Feb 24, 2023

agones-bot commented Feb 25, 2023

agones-bot commented Feb 27, 2023

agones-bot commented Feb 27, 2023

agones-bot commented Feb 27, 2023

agones-bot commented Feb 27, 2023

igooch commented Feb 21, 2023 •

edited

Loading