Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable to go-client request dashboard #2998

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

chiayi
Copy link
Contributor

@chiayi chiayi commented Feb 24, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
This adds a variable to the go-client request dashboard so that you can drill down by controller, extensions, or all.

Which issue(s) this PR fixes:
Work on #2797

Special notes for your reviewer:
Here are some screenshots:
image

image

image

@chiayi chiayi requested review from roberthbailey and zmerlynn and removed request for dzlier-gcp February 24, 2023 22:36
@zmerlynn zmerlynn self-assigned this Feb 24, 2023
@google-oss-prow google-oss-prow bot added the lgtm label Feb 24, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiayi, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign ericfortin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2e4180bd-09be-41de-af51-82c2689e6d59

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@zmerlynn zmerlynn enabled auto-merge (squash) February 24, 2023 23:19
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 925bb44c-8a5b-4d0c-90cb-2f1adc2bfdb6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2998/head:pr_2998 && git checkout pr_2998
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-655e252-amd64

@zmerlynn zmerlynn merged commit 6127d06 into googleforgames:main Feb 24, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants