Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actually distinct webhook for Autopilot #3035

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented Mar 16, 2023

The sasecret-redacter webhook will be a stable indicator until we have a more robust way.

The webhook I implemented in #3032 is sadly present on GKE Standard as well (my bad).

Replaces #3033
Closes #3034

The `sasecret-redacter` webhook will be a stable indicator until we
have a more robust way.
@google-oss-prow google-oss-prow bot added the lgtm label Mar 16, 2023
@zmerlynn zmerlynn enabled auto-merge (squash) March 16, 2023 22:43
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign ericfortin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2a70c99a-0006-401d-8a02-b2ea5e23b2e3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3035/head:pr_3035 && git checkout pr_3035
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-f8e890e-amd64

@zmerlynn zmerlynn merged commit dc592e9 into googleforgames:main Mar 16, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/bug These are bugs. label Apr 10, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autopilot cloud product detection is broken on GKE Autopilot 1.26
4 participants