Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm test instruction cleanup in Agones doc #3052

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind cleanup

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@Kalaiselvi84 Kalaiselvi84 added the kind/cleanup Refactoring code, fixing up documentation, etc label Mar 29, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Mar 29, 2023
@Kalaiselvi84 Kalaiselvi84 requested a review from markmandel March 29, 2023 19:56
@google-oss-prow google-oss-prow bot requested a review from EricFortin March 29, 2023 19:56
@markmandel markmandel linked an issue Mar 29, 2023 that may be closed by this pull request
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 36193077-e879-46f5-a76f-e37963a7629c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Failure on e2e on autopilot

Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.26: Step #1 - "e2e-feature-gates": === FAIL: test/e2e TestGameServerSetPlayerCapacity/initial_capacity_set (115.80s)
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.26: Step #1 - "e2e-feature-gates": time="2023-03-29 20:28:08.450" level=info msg="waiting for fleet condition" fleet=preferred-cgv9f test=TestGameServerAllocationPreferredSelection
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.26: Step #1 - "e2e-feature-gates": time="2023-03-29 20:28:08.652" level=info msg="Waiting for states to match" awaitingState=Ready currentState=Starting gs=game-server6x5pr test=TestPlayerConnectWithCapacityZero
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.26: Step #1 - "e2e-feature-gates": time="2023-03-29 20:28:09.053" level=info msg="Checking Fleet Ready replicas" expected=150 fleet=preferred-vmktg fleetStatus="{Replicas:150 ReadyReplicas:9 ReservedReplicas:0 AllocatedReplicas:0 Players:0xc000585ec0}" test=TestGameServerAllocationDuringMultipleAllocationClients
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.26: Step #1 - "e2e-feature-gates": time="2023-03-29 20:28:09.453" level=info msg="Checking Fleet Ready replicas" expected=3 fleet=simple-fleet-1.07tnkv fleetStatus="{Replicas:4 ReadyReplicas:2 ReservedReplicas:0 AllocatedReplicas:1 Players:0xc0003b6630}" test=TestAutoscalerBasicFunctions
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.26: Step #1 - "e2e-feature-gates": time="2023-03-29 20:28:09.651" level=info msg="Checking Fleet Ready replicas" expected=3 fleet=simple-fleet-1.0bbzkx fleetStatus="{Replicas:3 ReadyReplicas:2 ReservedReplicas:0 AllocatedReplicas:0 Players:0xc00057ca00}" test=TestFleetStrategyValidation
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.26: Step #1 - "e2e-feature-gates":     gameserver_test.go:1050: Could not get a GameServer ready: waiting for {game-server [{udp-port Dynamic <nil> 7654 0 UDP}] {false 0 0 0}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] []} {[] [] [{game-server us-docker.pkg.dev/agones-images/examples/simple-game-server:0.14 [] []  [] [] [] {map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}] map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}]} [] [] nil nil nil nil   IfNotPresent nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil> nil <nil>}} 0xc000433a78 map[] map[] <nil>} GameServer instance readiness timed out (): waiting for GameServer 1680121195/game-serverg5p8q to be Ready: GameServer reached terminal state Unhealthy
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.26: Step #1 - "e2e-feature-gates":     --- FAIL: TestGameServerSetPlayerCapacity/initial_capacity_set (115.80s)
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.26: Step #1 - "e2e-feature-gates": 
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.26: Step #1 - "e2e-feature-gates": === FAIL: test/e2e TestGameServerSetPlayerCapacity (127.60s)

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 89528457-27f8-45f7-b972-854a22d37ccd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8864f64d-1d09-4d50-af1e-479380db1da0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3052/head:pr_3052 && git checkout pr_3052
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-36f8879-amd64

@markmandel markmandel merged commit 60f72f0 into googleforgames:main Mar 29, 2023
Kalaiselvi84 added a commit to Kalaiselvi84/agones that referenced this pull request Mar 31, 2023
@Kalaiselvi84 Kalaiselvi84 deleted the issue/275597796 branch March 15, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The images and instructions around the helm test seem incomplete
3 participants