Compilation errors on simple-game-server #3054

markmandel · 2023-03-30T17:49:35Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind docum
entation
/kind feature
/kind hotfix

What this PR does / Why we need it:

We can now build the image again! 😄

Fix for updated signals.NewSigKillContext()
go mod tidy required after recent dependabot fixes.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

We should wait on #3050 before building a new example image with this version'd tag, and moving the e2e tests over to it.

agones-bot · 2023-03-30T19:30:13Z

Build Failed 😱

Build Id: eab30be9-1883-4c6e-839d-9c7927e0bbb1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-03-30T19:34:27Z

Failed since it was waiting to become leader.

google-oss-prow · 2023-03-31T06:53:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-03-31T06:53:21Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-03-31T07:41:46Z

Build Failed 😱

Build Id: fe83bd38-0108-4e46-b7cd-5b8463be2191

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn · 2023-04-04T15:51:48Z

We should keep the go.mod changes but #3050 is going to fix the compilation issues.

markmandel · 2023-04-04T15:54:23Z

We should keep the go.mod changes but #3050 is going to fix the compilation issues.

I figured I'd just fix whatever conflicts came up once #3050 was merged.

* Fix for updated `signals.NewSigKillContext()` * `go mod tidy` required after recent dependabot fixes.

agones-bot · 2023-04-04T23:22:06Z

Build Succeeded 👏

Build Id: 2e7a728d-ba14-46a5-9862-02b29fc33236

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-3dfe822-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-3dfe822-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-3dfe822-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-3dfe822-amd64
Linux C++ SDK (build): agonessdk-1.31.0-3dfe822-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-3dfe822-amd64.zip

A preview of the website (the last 30 builds are retained):

https://3dfe822-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3054/head:pr_3054 && git checkout pr_3054
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-3dfe822-amd64

agones-bot · 2023-04-05T05:10:22Z

Build Failed 😱

Build Id: c997e7d0-2e9e-4f82-a629-cab1801afc49

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2023-04-05T18:57:32Z

Now that #3050 has merged, can we update the issue title? This no longer fixes compilation issues, but it does clean up the dependencies for the executable.

markmandel · 2023-04-05T19:02:13Z

Now that #3050 has merged, can we update the issue title? This no longer fixes compilation issues, but it does clean up the dependencies for the executable.

It does still fix compilation issues - as otherwise go will complain that a go mod tidy is required before it will build.

agones-bot · 2023-04-05T19:24:38Z

Build Succeeded 👏

Build Id: f0161102-981f-4cf1-afcc-e60cbc303462

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-f8d35fe-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-f8d35fe-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-f8d35fe-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-f8d35fe-amd64
Linux C++ SDK (build): agonessdk-1.31.0-f8d35fe-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-f8d35fe-amd64.zip

A preview of the website (the last 30 builds are retained):

https://f8d35fe-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3054/head:pr_3054 && git checkout pr_3054
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-f8d35fe-amd64

agones-bot · 2023-04-05T19:41:59Z

Build Failed 😱

Build Id: c213b608-837d-4702-b7a2-9f259a21ccdb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-04-05T19:49:25Z

SDK conformance test flake. This is a new one:

+ go run sdk-client-test.go
{"ctlConf":{"Address":"","IsLocal":false,"LocalFile":"","Delay":3,"Timeout":40,"Test":"ready,allocate,setlabel,setannotation,gameserver,health,shutdown,watch,reserve,getplayercapacity,setplayercapacity,playerconnect,playerdisconnect,getplayercount,isplayerconnected,getconnectedplayers","TestSdkName":"go","GRPCPort":9001,"HTTPPort":9101},"featureGates":"CountsAndLists=false\u0026CustomFasSyncInterval=true\u0026Example=false\u0026FleetAllocationOverflow=false\u0026PlayerAllocationFilter=false\u0026PlayerTracking=true\u0026PodHostname=false\u0026ResetMetricsOnDelete=false\u0026SDKGracefulTermination=true\u0026SafeToEvict=true\u0026SplitControllerAndExtensions=false\u0026StateAllocationFilter=true","message":"Starting sdk sidecar","severity":"info","source":"main","time":"2023-04-05T19:37:13.745304351Z","version":"1.31.0-5a65b23"}
{"message":"Waiting 3 seconds before starting","severity":"info","source":"main","time":"2023-04-05T19:37:13.745560534Z"}
{"message":"shutting down sdk server","severity":"info","source":"main","time":"2023-04-05T19:37:15.308444541Z"}
{"message":"Could not find a request which was expected","request":"allocate","sdkName":"node","severity":"error","source":"*sdkserver.LocalSDKServer","time":"2023-04-05T19:37:15.309229325Z"}
{"expected":["ready","allocate","setlabel","setannotation","gameserver","health","shutdown","watch","reserve"],"message":"Testing Failed","received":["ready","watch","gameserver","setlabel","health","reserve","ready"],"sdkName":"node","severity":"info","source":"*sdkserver.LocalSDKServer","time":"2023-04-05T19:37:15.309313972Z"}
Watch ERROR Error: 14 UNAVAILABLE: Connection dropped
    at Object.callErrorFromStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/call.js:31:19)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:360:49)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:328:181)
    at /go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/call-stream.js:188:78
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11)
for call at
    at ServiceClientImpl.makeServerStreamRequest (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:343:34)
    at ServiceClientImpl.watchGameServer (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/make-client.js:105:19)
    at AgonesSDK.watchGameServer (/go/src/agones.dev/agones/sdks/nodejs/src/agonesSDK.js:132:30)
    at connect (/go/src/agones.dev/agones/test/sdk/nodejs/testSDKClient.js:25:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 14,
  details: 'Connection dropped',
  metadata: Metadata { internalRepr: Map(0) {}, options: {} }
}
Error: 14 UNAVAILABLE: Connection dropped
    at Object.callErrorFromStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/call.js:31:19)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:195:52)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:365:141)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:328:181)
    at /go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/call-stream.js:188:78
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11)
for call at
    at ServiceClientImpl.makeUnaryRequest (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:163:34)
    at ServiceClientImpl.reserve (/go/src/agones.dev/agones/sdks/nodejs/node_modules/@grpc/grpc-js/build/src/make-client.js:105:19)
    at /go/src/agones.dev/agones/sdks/nodejs/src/agonesSDK.js:178:16
    at new Promise (<anonymous>)
    at AgonesSDK.reserve (/go/src/agones.dev/agones/sdks/nodejs/src/agonesSDK.js:177:10)
    at connect (/go/src/agones.dev/agones/test/sdk/nodejs/testSDKClient.js:45:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 14,
  details: 'Connection dropped',
  metadata: Metadata { internalRepr: Map(0) {}, options: {} }

agones-bot · 2023-04-05T22:09:39Z

Build Succeeded 👏

Build Id: 12529a68-af3c-47df-be2e-de105704cb4a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-5a65b23-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-5a65b23-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-5a65b23-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-5a65b23-amd64
Linux C++ SDK (build): agonessdk-1.31.0-5a65b23-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-5a65b23-amd64.zip

A preview of the website (the last 30 builds are retained):

https://5a65b23-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3054/head:pr_3054 && git checkout pr_3054
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-5a65b23-amd64

agones-bot · 2023-04-06T00:09:24Z

Build Failed 😱

Build Id: 94c954be-37be-40e6-a82d-b32972b16480

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-06T03:00:15Z

Build Succeeded 👏

Build Id: 1027bbb2-2672-46c3-9002-8ff59ae52a96

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-3978963-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-3978963-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-3978963-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-3978963-amd64
Linux C++ SDK (build): agonessdk-1.31.0-3978963-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-3978963-amd64.zip

A preview of the website (the last 30 builds are retained):

https://3978963-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3054/head:pr_3054 && git checkout pr_3054
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-3978963-amd64

agones-bot · 2023-04-06T06:22:35Z

Build Failed 😱

Build Id: 4799f76b-3bff-4016-a25a-fe0afffc246c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-06T17:35:17Z

Build Succeeded 👏

Build Id: 3e0396f8-ccdb-4afc-84fb-f2d8398acb2e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.31.0-d42193f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.31.0-d42193f-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.31.0-d42193f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.31.0-d42193f-amd64
Linux C++ SDK (build): agonessdk-1.31.0-d42193f-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.31.0-d42193f-amd64.zip

A preview of the website (the last 30 builds are retained):

https://d42193f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3054/head:pr_3054 && git checkout pr_3054
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-d42193f-amd64

* Fix for updated `signals.NewSigKillContext()` * `go mod tidy` required after recent dependabot fixes.

markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Mar 30, 2023

markmandel requested review from roberthbailey, gongmax and Kalaiselvi84 March 30, 2023 17:49

google-oss-prow bot requested a review from EricFortin March 30, 2023 17:49

google-oss-prow bot added approved size/L labels Mar 30, 2023

gongmax approved these changes Mar 30, 2023

View reviewed changes

google-oss-prow bot assigned gongmax Mar 30, 2023

google-oss-prow bot added the lgtm label Mar 30, 2023

markmandel enabled auto-merge (squash) March 30, 2023 20:20

roberthbailey approved these changes Mar 31, 2023

View reviewed changes

google-oss-prow bot assigned roberthbailey Mar 31, 2023

google-oss-prow bot removed the lgtm label Mar 31, 2023

Compilation errors on simple-game-server

99ef110

* Fix for updated `signals.NewSigKillContext()` * `go mod tidy` required after recent dependabot fixes.

markmandel force-pushed the cleanup/simple-game-server-errors branch from d1f222f to 99ef110 Compare April 4, 2023 20:25

Merge branch 'main' into cleanup/simple-game-server-errors

3dfe822

Merge branch 'main' into cleanup/simple-game-server-errors

c80f09e

Merge branch 'main' into cleanup/simple-game-server-errors

f8d35fe

Merge branch 'main' into cleanup/simple-game-server-errors

5a65b23

Merge branch 'main' into cleanup/simple-game-server-errors

3978963

Merge branch 'main' into cleanup/simple-game-server-errors

d42193f

markmandel merged commit 0ee2d76 into googleforgames:main Apr 6, 2023

markmandel deleted the cleanup/simple-game-server-errors branch April 6, 2023 17:35

Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023

Kalaiselvi84 pushed a commit to Kalaiselvi84/agones that referenced this pull request Apr 11, 2023

Compilation errors on simple-game-server (googleforgames#3054)

d0f6fe2

* Fix for updated `signals.NewSigKillContext()` * `go mod tidy` required after recent dependabot fixes.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compilation errors on simple-game-server #3054

Compilation errors on simple-game-server #3054

markmandel commented Mar 30, 2023

agones-bot commented Mar 30, 2023

markmandel commented Mar 30, 2023

google-oss-prow bot commented Mar 31, 2023

google-oss-prow bot commented Mar 31, 2023

agones-bot commented Mar 31, 2023

zmerlynn commented Apr 4, 2023

markmandel commented Apr 4, 2023

agones-bot commented Apr 4, 2023

agones-bot commented Apr 5, 2023

roberthbailey commented Apr 5, 2023

markmandel commented Apr 5, 2023

agones-bot commented Apr 5, 2023

agones-bot commented Apr 5, 2023

markmandel commented Apr 5, 2023

agones-bot commented Apr 5, 2023

agones-bot commented Apr 6, 2023

agones-bot commented Apr 6, 2023

agones-bot commented Apr 6, 2023

agones-bot commented Apr 6, 2023

Compilation errors on simple-game-server #3054

Compilation errors on simple-game-server #3054

Conversation

markmandel commented Mar 30, 2023

agones-bot commented Mar 30, 2023

markmandel commented Mar 30, 2023

google-oss-prow bot commented Mar 31, 2023

google-oss-prow bot commented Mar 31, 2023

agones-bot commented Mar 31, 2023

zmerlynn commented Apr 4, 2023

markmandel commented Apr 4, 2023

agones-bot commented Apr 4, 2023

agones-bot commented Apr 5, 2023

roberthbailey commented Apr 5, 2023

markmandel commented Apr 5, 2023

agones-bot commented Apr 5, 2023

agones-bot commented Apr 5, 2023

markmandel commented Apr 5, 2023

agones-bot commented Apr 5, 2023

agones-bot commented Apr 6, 2023

agones-bot commented Apr 6, 2023

agones-bot commented Apr 6, 2023

agones-bot commented Apr 6, 2023