Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licence to cancelot.sh #3055

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Also includes a bash bang line at the top too.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Also includes a bash bang line at the top too.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Mar 30, 2023
@markmandel markmandel requested a review from gongmax March 30, 2023 18:13
Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 97e01756-9c7e-4c64-987d-ed5aeb00ae55

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel enabled auto-merge (squash) March 30, 2023 20:19
@gongmax
Copy link
Collaborator

gongmax commented Mar 30, 2023

CI timed out waiting for becoming a leader. Retrying.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f4e8901d-d87f-4890-b111-588d21066c4c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3055/head:pr_3055 && git checkout pr_3055
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-ff20e15-amd64

@markmandel markmandel merged commit d98cd1b into googleforgames:main Mar 30, 2023
@markmandel markmandel deleted the cleanup/licence-cancelot branch March 30, 2023 22:10
Kalaiselvi84 pushed a commit to Kalaiselvi84/agones that referenced this pull request Mar 31, 2023
Also includes a bash bang line at the top too.
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants