Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to Global Scale Demo from Agones Examples page #3064

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Link to Global Scale Demo from Agones Examples page #3064

merged 5 commits into from
Apr 4, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind cleanup
/kind feature

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@Kalaiselvi84 Kalaiselvi84 added kind/feature New features for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 3, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 3, 2023
@Kalaiselvi84 Kalaiselvi84 requested a review from markmandel April 3, 2023 18:47
@google-oss-prow google-oss-prow bot requested a review from aLekSer April 3, 2023 18:47
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Apr 3, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 82c6192a-7936-468d-a3c8-ac338de50b94

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel
markmandel reviewed Apr 4, 2023
View reviewed changes
site/content/en/docs/Examples/_index.md Outdated
Comment on lines 53 to 55

## Global Scale Demo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Global Scale Demo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of this header, we can put the entry for Global Scale Demo right below Space Agon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global multiplayer demo link is added below the Space Agon

@markmandel
Copy link
Member

Ah, you will also need to fix the link in the FAQ page:

site/docs/faq/index.html
  hash does not exist --- site/docs/faq/index.html --> /site/docs/examples/#integration-with-open-match
  hash does not exist --- site/docs/faq/index.html --> /site/docs/third-party-content/examples/#integration-with-open-match

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7b63ebc6-58af-43aa-885f-707f9a8f9daf

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 17a72fd4-e650-453c-9114-2b339fb766d3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0b7181a4-1ccc-4297-885b-22eb9f0eb068

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 088dfb9e-83bf-491c-87e0-514f5af14d8b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3064/head:pr_3064 && git checkout pr_3064
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-6cad301-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Apr 4, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 3fd7b72 into googleforgames:main Apr 4, 2023
Kalaiselvi84 added a commit to Kalaiselvi84/agones that referenced this pull request Apr 11, 2023
@Kalaiselvi84 @markmandel
Link to Global Scale Demo from Agones Examples page (googleforgames#3064
cd08de6 
)

* Header update in examples doc and added Global scale demo in the list

* small changes in doc for Create an Autopilot mode cluster for Agones

* Multi player link update in FAQ file

---------

Co-authored-by: Mark Mandel <markmandel@google.com>
@Kalaiselvi84 Kalaiselvi84 deleted the issues/276757096 branch March 15, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@markmandel markmandel

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New features for Agones lgtm size/S
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Kalaiselvi84 @agones-bot @markmandel