Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameServer Allocation Filtering for Counts and Lists #3065

Merged
merged 2 commits into from
Apr 7, 2023
Merged

GameServer Allocation Filtering for Counts and Lists #3065

merged 2 commits into from
Apr 7, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Apr 3, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds CounterSelector and ListSelector for Game Server Allocation filtering as part of feature CountsAndLists.

  • Allocation filter on count value (min, max)
  • Allocation filter on count available capacity (min, max)
  • Allocation filter on list available capacity (min, max)
  • Allocation filter on if single value is contained in a list

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@google-oss-prow google-oss-prow bot requested review from aLekSer and EricFortin April 3, 2023 23:07
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bf5dd12a-476f-499a-be10-6aefa3df2063

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from d739b81 to 48dfc4c Compare April 3, 2023 23:16
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 62fae0eb-cec1-49fc-8e3b-c72897aea973

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 48dfc4c to 341c5ce Compare April 3, 2023 23:25
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 03ba2112-aefa-4928-aad9-00d9de9be3b0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 0b63165 to 8982a7b Compare April 4, 2023 01:19
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c8e0805a-ff89-4970-8ecd-3fdad2988168

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 3 times, most recently from a2f3220 to ba878d5 Compare April 4, 2023 16:50
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bfb1b8bd-d27c-4ee8-b23b-128557299928

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 14d202ed-164f-49ae-93ea-6afd4dc92083

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from ba878d5 to a3fa64f Compare April 4, 2023 17:07
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7e574b08-33b3-4abf-881a-94829ff7bc34

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch marked this pull request as ready for review April 4, 2023 20:03
@google-oss-prow google-oss-prow bot requested a review from cyriltovena April 4, 2023 20:03
@igooch igooch changed the title GameServer Allocation Filtering and Sorting for Counts and Lists GameServer Allocation Filtering for Counts and Lists Apr 4, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 33507c99-b91a-4b64-bac8-068b0f490fb4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3065/head:pr_3065 && git checkout pr_3065
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-a3fa64f-amd64

gongmax
gongmax reviewed Apr 4, 2023
View reviewed changes
pkg/apis/allocation/v1/gameserverallocation.go Outdated Show resolved Hide resolved
pkg/apis/allocation/v1/gameserverallocation.go Outdated Show resolved Hide resolved
pkg/apis/allocation/v1/gameserverallocation.go Show resolved Hide resolved
pkg/apis/allocation/v1/gameserverallocation.go Outdated Show resolved Hide resolved
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from a3fa64f to 26e0850 Compare April 5, 2023 16:16
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6b6d6591-9ec1-4115-a844-ebc100a59ccc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 26e0850 to 7e55089 Compare April 5, 2023 17:19
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d5a5aed6-5fc5-4b79-b4c1-038b297be507

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 7e55089 to 0d6c5b2 Compare April 5, 2023 17:35
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 8c766dd to 68b79a4 Compare April 6, 2023 21:00
gongmax
gongmax approved these changes Apr 6, 2023
View reviewed changes
pkg/apis/allocation/v1/gameserverallocation.go Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added the lgtm label Apr 6, 2023
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 68b79a4 to b8f2541 Compare April 6, 2023 22:06
@google-oss-prow google-oss-prow bot removed the lgtm label Apr 6, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 452a371a-ba95-4a05-8779-f891539f1377

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cabf6295-9d2f-4658-b4e7-b18e1533f128

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3065/head:pr_3065 && git checkout pr_3065
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-b8f2541-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Apr 7, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e6190045-b534-4151-9098-a43d7ff8cabc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3065/head:pr_3065 && git checkout pr_3065
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-3d882d1-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 3d882d1 to 9fe0dc8 Compare April 7, 2023 18:54
@google-oss-prow google-oss-prow bot removed the lgtm label Apr 7, 2023
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 0fe7397 to e8dd7d6 Compare April 7, 2023 18:57
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from e8dd7d6 to 2268327 Compare April 7, 2023 19:16
@google-oss-prow google-oss-prow bot added the lgtm label Apr 7, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2b266605-1a1b-4333-b339-46c1b98250b4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3065/head:pr_3065 && git checkout pr_3065
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-2268327-amd64

@gongmax gongmax merged commit 3109fe1 into googleforgames:main Apr 7, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Apr 10, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 10, 2023
Kalaiselvi84 pushed a commit to Kalaiselvi84/agones that referenced this pull request Apr 11, 2023
@igooch @Kalaiselvi84
GameServer Allocation Filtering for Counts and Lists (googleforgames#…
e2f4e9d 
…3065)

* Adds Counter Selectors and List Selectors to GameServerAllocation Selectors

* Generated files
@igooch igooch mentioned this pull request Jan 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@EricFortin EricFortin Awaiting requested review from EricFortin

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@markmandel markmandel

@gongmax gongmax

Labels
approved kind/feature New features for Agones lgtm size/XXL
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
5 participants
@igooch @agones-bot @markmandel @gongmax @Kalaiselvi84