Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple-game-server with latest version 0.15 #3078

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind cleanup

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@Kalaiselvi84 Kalaiselvi84 added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 7, 2023
@Kalaiselvi84 Kalaiselvi84 requested a review from markmandel April 7, 2023 18:40
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0ca03a2e-f80a-4a0c-86cb-cfe8598173a6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3078/head:pr_3078 && git checkout pr_3078
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-61e5334-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) April 7, 2023 21:55
@google-oss-prow google-oss-prow bot removed the lgtm label Apr 8, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 297a281f-1d63-4752-b53f-a2d9b5431bb5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3078/head:pr_3078 && git checkout pr_3078
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-88212b7-amd64

@markmandel
Copy link
Member

So this is hilarious:

The following contributors were found for this pull request:

white_check_mark https://github.com/googleforgames/agones/commit/61e533442f805684040392f21f3ab10f7db94d01 Author: @Kalaiselvi84 <kal******im​@google.com>
x https://github.com/googleforgames/agones/commit/88212b7bb1e0043232b54e6e2d68e16c3c98cf2a Author: @github-actions[bot] <41898282+github-actions[bot]​@users.noreply.github.com>

So the PR was updated - but CLA check fails for the github actions bot - since that is the token we use 🤦🏻

@markmandel
Copy link
Member

Turned off workflow, and rebased again main. This should be fine now.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ed42a691-d01b-4fc3-81f8-30b91f79e3e5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 87ba569e-49c7-4c06-87b7-2411e85ab1d5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c7488e83-c0c0-49c3-b097-ce71f1dff6b4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3078/head:pr_3078 && git checkout pr_3078
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.31.0-be175ea-amd64

@markmandel markmandel merged commit 06921ea into googleforgames:main Apr 10, 2023
Kalaiselvi84 added a commit to Kalaiselvi84/agones that referenced this pull request Apr 11, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.31.0 milestone Apr 11, 2023
@Kalaiselvi84 Kalaiselvi84 deleted the issues/277239505 branch March 15, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants