Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Stable Network ID #3088

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Attempting to alleviate some confusion about Stable Network ID, as it read as if the feature would enable a feature like the ExternalDNS provider -- whereas it's actually only for use within the cluster.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Attempting to alleviate some confusion about Stable Network ID, as it
read as if the feature would enable a feature like the `ExternalDNS`
provider -- whereas it's actually only for use within the cluster.
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 12, 2023
Copy link
Collaborator

@rcreasey rcreasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helped clarify the situation for our use case. 👍

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5bf1a1da-78f1-4cb8-b692-e53ce51f9098

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3088/head:pr_3088 && git checkout pr_3088
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-c22185c-amd64

@markmandel markmandel requested review from zmerlynn and gongmax and removed request for cyriltovena and EricFortin April 13, 2023 21:26
@google-oss-prow google-oss-prow bot removed the lgtm label Apr 13, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, rcreasey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn enabled auto-merge (squash) April 13, 2023 21:56
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5ba48981-66f9-467d-abe3-f67abb65f438

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3088/head:pr_3088 && git checkout pr_3088
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-7f229f2-amd64

@zmerlynn zmerlynn merged commit 88e3b80 into googleforgames:main Apr 13, 2023
@markmandel markmandel deleted the docs/stable-network-id branch April 17, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants