-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push-Chart to Helm Repo on GCS #3114
Conversation
Build Succeeded 👏 Build Id: 942fd1e2-64a8-42b8-8dd3-537ca649bc77 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
build/Makefile
Outdated
@@ -282,7 +282,7 @@ build-chart: $(ensure-build-image) | |||
|
|||
# push the current chart to google cloud storage and update the index | |||
push-chart: $(ensure-build-image) build-chart | |||
docker run --rm $(common_mounts) -w $(workdir_path) $(build_tag) bash -c \ | |||
docker run --network=cloudbuild --rm $(common_mounts) -w $(workdir_path) $(build_tag) bash -c \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's set this up the same as we have other targets, so have it as:
docker run --network=cloudbuild --rm $(common_mounts) -w $(workdir_path) $(build_tag) bash -c \ | |
docker run $(DOCKER_RUN_ARGS) --rm $(common_mounts) -w $(workdir_path) $(build_tag) bash -c \ |
And then pass in the --network=cloudbuild
from the post_cloudbuild.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it done.
Build Succeeded 👏 Build Id: 76884993-521c-45f6-adfc-a3048747d26b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: dd1dcd77-5a14-4dc6-b2ba-65ede7571fe4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, Kalaiselvi84 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: