Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PodHostName to Beta #3118

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Move PodHostName to Beta #3118

merged 7 commits into from
Apr 26, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@Kalaiselvi84 Kalaiselvi84 added kind/feature New features for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 22, 2023
@Kalaiselvi84 Kalaiselvi84 requested review from markmandel and removed request for cyriltovena and aLekSer April 22, 2023 18:25
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 40ff2411-fca4-4504-97f1-f85c9468ae60

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3118/head:pr_3118 && git checkout pr_3118
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-4b059db-amd64

@Kalaiselvi84 Kalaiselvi84 requested a review from zmerlynn April 24, 2023 16:33
@google-oss-prow google-oss-prow bot added the lgtm label Apr 24, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kalaiselvi84, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn
Copy link
Collaborator

We talked offline and you'll need to update gameserver.md (just reminding myself).

@google-oss-prow google-oss-prow bot removed the lgtm label Apr 24, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@Kalaiselvi84
Copy link
Contributor Author

We talked offline and you'll need to update gameserver.md (just reminding myself).

The gameserver.md file has been updated from alpha to beta.

@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review April 24, 2023 19:24
@google-oss-prow google-oss-prow bot requested a review from aLekSer April 24, 2023 19:24
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dadb1a30-5baa-4933-baa4-57a32900e36f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3118/head:pr_3118 && git checkout pr_3118
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-a1f49a7-amd64

@zmerlynn zmerlynn enabled auto-merge (squash) April 24, 2023 19:58
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 950c5386-6922-40ee-a559-7229c1a9e6ad

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: efadf49d-dbe9-4864-a5a5-ccda87892755

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 90fd3291-a720-4b1f-b1bd-34c3f222b2b3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e30826bf-7ee8-4c88-92a7-77bceac9d3c3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 19f18b24-cfd4-4279-a8cd-6fa6e7ffa92d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ba488344-dbde-44a5-b55d-c78ccfd5ed7f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3118/head:pr_3118 && git checkout pr_3118
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-cfd88cc-amd64

@zmerlynn zmerlynn merged commit d436374 into googleforgames:main Apr 26, 2023
@markmandel markmandel mentioned this pull request Apr 27, 2023
Closed
@Kalaiselvi84 Kalaiselvi84 deleted the podHostName-to-beta branch March 15, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerlynn zmerlynn zmerlynn approved these changes

@markmandel markmandel Awaiting requested review from markmandel

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@zmerlynn zmerlynn

Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New features for Agones size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kalaiselvi84 @agones-bot @zmerlynn