Added labels to the agones.allocator #3125

Kalaiselvi84 · 2023-04-26T16:06:21Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3093

Special notes for your reviewer:

agones-bot · 2023-04-26T16:23:20Z

Build Failed 😱

Build Id: fa611a27-0e46-496f-978a-c2bad5ccbea1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

install/helm/agones/values.yaml

agones-bot · 2023-04-27T05:33:23Z

Build Succeeded 👏

Build Id: 05cffcac-f387-4841-9bb9-cacdf0a74b46

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-1198956-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-1198956-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-1198956-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-1198956-amd64
Linux C++ SDK (build): agonessdk-1.32.0-1198956-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-1198956-amd64.zip

A preview of the website (the last 30 builds are retained):

https://1198956-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3125/head:pr_3125 && git checkout pr_3125
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-1198956-amd64

agones-bot · 2023-04-27T06:18:00Z

Build Failed 😱

Build Id: d8ec5534-8238-4c74-b681-5c95860de705

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-27T07:25:57Z

Build Failed 😱

Build Id: 263f9616-5006-4544-9188-f75f948eaef5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-27T16:45:53Z

Build Succeeded 👏

Build Id: 3a2f8f06-effb-47e4-acd3-54c27168db5d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-43987a7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-43987a7-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-43987a7-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-43987a7-amd64
Linux C++ SDK (build): agonessdk-1.32.0-43987a7-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-43987a7-amd64.zip

A preview of the website (the last 30 builds are retained):

https://43987a7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3125/head:pr_3125 && git checkout pr_3125
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-43987a7-amd64

markmandel

Small docs change, but otherwise good to go.

markmandel · 2023-04-27T18:32:22Z

site/content/en/docs/Installation/Install Agones/helm.md

@@ -201,6 +201,7 @@ The following tables lists the configurable parameters of the Agones chart and t
 | `agones.allocator.tolerations`                           | Allocator [toleration][toleration] labels for pod assignment                                                                                                                                                            | `[]`                               |
 | `agones.allocator.affinity`                              | Allocator [affinity][affinity] settings for pod assignment                                                                                                                                                              | `{}`                               |
 | `agones.allocator.annotations`                           | [Annotations][annotations] added to the Agones allocator pods                                                                                                                                                           | `{}`                               |
+| `agones.allocator.labels`                           | [Labels][labels] added to the Agones allocator pods                                                                                                                                                           | `{}`                               |


This table will need to added to the feature shortcoded table at the bottom so they don't show up in documentation when merged into main (docs get updated immeadiately)
https://agones.dev/site/docs/contribute/#within-a-page

#2961 is a good example

I've updated the helm file, please review and let me know if there's anything that needs further attention..

…ones into issues/279057770

agones-bot · 2023-04-28T03:31:14Z

Build Succeeded 👏

Build Id: f3cb718f-3b53-4e2d-bee6-8349d485ca80

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-45f7840-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-45f7840-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-45f7840-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-45f7840-amd64
Linux C++ SDK (build): agonessdk-1.32.0-45f7840-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-45f7840-amd64.zip

A preview of the website (the last 30 builds are retained):

https://45f7840-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3125/head:pr_3125 && git checkout pr_3125
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-45f7840-amd64

markmandel

Just realised this was missing a step.

Also hope you don't mind but I edited the description to add the "closes" to the issue so it would actually close the issue.

markmandel · 2023-04-28T21:27:39Z

install/helm/agones/values.yaml

@@ -36,6 +36,7 @@ agones:
    allocator:
      name: agones-allocator
      annotations: {}
+      labels: {}


I just realised something! This value hasn't been applied to the actual service Deployment! We will need to do that as well.

https://github.com/googleforgames/agones/blob/main/install/helm/agones/templates/service/allocation.yaml

I have added labels in this allocation.yaml file, please share your suggestions

agones-bot · 2023-04-28T22:02:33Z

Build Failed 😱

Build Id: f5eb7d77-a70d-4724-9b1c-35dba6dd7c54

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-05-01T18:05:47Z

Looks like a flake:

--- FAIL: TestAllocatorAllocate (2.65s)
    allocator_test.go:120: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:120
        	Error:      	Expected value not to be nil.
        	Test:       	TestAllocatorAllocate

markmandel · 2023-05-01T18:32:33Z

install/helm/agones/templates/service/allocation.yaml

@@ -160,6 +160,9 @@ spec:
 {{- end }}
 {{- if .Values.agones.allocator.annotations }}
 {{- toYaml .Values.agones.allocator.annotations | nindent 8 }}
+{{- end }}
+{{- if .Values.agones.allocator.labels }}


Looks good - just checking if you had a chance to do any manual testing on this? (I don't think there's any better way to actually test this).

Easiest way might be to use make install and pass in some extra HELM_ARGS and make sure the Deployment labels are good.

I have validated the labels manually per your guidance

Thanks for the validation - but I just realised after looking at it, that these values are showing up in the annotations: section.

We should move this code up to above line 152, so it sits under labels: - then it should be good to go.

The values have been moved to the labels section

agones-bot · 2023-05-02T18:52:37Z

Build Failed 😱

Build Id: 12b838fd-72fc-43f0-b78c-5fc07aec6fe4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-05T23:15:37Z

Build Succeeded 👏

Build Id: 8a643f02-2662-4e04-adf6-7a0a7226209a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-52d7ae5-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-52d7ae5-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-52d7ae5-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-52d7ae5-amd64
Linux C++ SDK (build): agonessdk-1.32.0-52d7ae5-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-52d7ae5-amd64.zip

A preview of the website (the last 30 builds are retained):

https://52d7ae5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3125/head:pr_3125 && git checkout pr_3125
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-52d7ae5-amd64

markmandel

Looks good!

markmandel

Looks good!

google-oss-prow · 2023-05-05T23:40:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Added labels for the agones.allocator

1d11486

google-oss-prow bot added the do-not-merge/work-in-progress label Apr 26, 2023

google-oss-prow bot requested review from cyriltovena and roberthbailey April 26, 2023 16:06

google-oss-prow bot added the size/XS label Apr 26, 2023

Kalaiselvi84 requested review from markmandel and removed request for cyriltovena April 26, 2023 16:06

markmandel reviewed Apr 27, 2023

View reviewed changes

install/helm/agones/values.yaml Show resolved Hide resolved

Labels added to helm.md

1198956

Kalaiselvi84 marked this pull request as ready for review April 27, 2023 04:44

google-oss-prow bot removed the do-not-merge/work-in-progress label Apr 27, 2023

google-oss-prow bot requested a review from cyriltovena April 27, 2023 04:44

Merge branch 'main' into issues/279057770

43987a7

markmandel reviewed Apr 27, 2023

View reviewed changes

Kalaiselvi84 added 4 commits April 27, 2023 19:09

Labels added in the new configuration feature table

294ceca

added labels in the new config features table

9d619a9

Merge branch 'issues/279057770' of https://github.com/Kalaiselvi84/ag…

cbb20f1

…ones into issues/279057770

helm file update

45f7840

markmandel reviewed Apr 28, 2023

View reviewed changes

allocation.yaml file update

5d7819e

markmandel reviewed May 1, 2023

View reviewed changes

Merge branch 'main' into issues/279057770

cfe5524

label update

5ec3424

google-oss-prow bot added size/S and removed size/XS labels May 5, 2023

Merge branch 'main' into issues/279057770

52d7ae5

markmandel approved these changes May 5, 2023

View reviewed changes

google-oss-prow bot assigned markmandel May 5, 2023

markmandel approved these changes May 5, 2023

View reviewed changes

google-oss-prow bot added the lgtm label May 5, 2023

google-oss-prow bot added the approved label May 5, 2023

markmandel merged commit 8b56232 into googleforgames:main May 5, 2023

Kalaiselvi84 added the kind/feature New features for Agones label May 18, 2023

Kalaiselvi84 deleted the issues/279057770 branch March 15, 2024 01:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added labels to the agones.allocator #3125

Added labels to the agones.allocator #3125

Kalaiselvi84 commented Apr 26, 2023 •

edited by markmandel

Loading

agones-bot commented Apr 26, 2023

agones-bot commented Apr 27, 2023

agones-bot commented Apr 27, 2023

agones-bot commented Apr 27, 2023

agones-bot commented Apr 27, 2023

markmandel left a comment

markmandel Apr 27, 2023

Kalaiselvi84 Apr 28, 2023

agones-bot commented Apr 28, 2023

markmandel left a comment

markmandel Apr 28, 2023

Kalaiselvi84 Apr 28, 2023

agones-bot commented Apr 28, 2023

markmandel commented May 1, 2023

markmandel May 1, 2023

Kalaiselvi84 May 5, 2023

markmandel May 5, 2023

Kalaiselvi84 May 5, 2023

agones-bot commented May 2, 2023

agones-bot commented May 5, 2023

markmandel left a comment

markmandel left a comment

google-oss-prow bot commented May 5, 2023

Added labels to the agones.allocator #3125

Added labels to the agones.allocator #3125

Conversation

Kalaiselvi84 commented Apr 26, 2023 • edited by markmandel Loading

agones-bot commented Apr 26, 2023

agones-bot commented Apr 27, 2023

agones-bot commented Apr 27, 2023

agones-bot commented Apr 27, 2023

agones-bot commented Apr 27, 2023

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Apr 28, 2023

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Apr 28, 2023

markmandel commented May 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented May 2, 2023

agones-bot commented May 5, 2023

markmandel left a comment

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented May 5, 2023

Kalaiselvi84 commented Apr 26, 2023 •

edited by markmandel

Loading