Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a branch for release #3127

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Creating a branch for release #3127

merged 3 commits into from
Apr 28, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@Kalaiselvi84 Kalaiselvi84 added kind/feature New features for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 27, 2023
@Kalaiselvi84 Kalaiselvi84 requested a review from markmandel April 27, 2023 21:36
@google-oss-prow google-oss-prow bot requested review from aLekSer and EricFortin April 27, 2023 21:36
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 53145d7e-148e-4a9c-a0f6-7ac17b7d3b46

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Apr 28, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 10f0ce49-a1b2-4ecb-b498-4b95a0276f53

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

gongmax
gongmax reviewed Apr 28, 2023
View reviewed changes
build/includes/release.mk Outdated
@echo "Starting release for version: $(RELEASE_VERSION)"

# switch to the right project
$(DOCKER_RUN) gcloud config configurations activate agones-images

git checkout -b release-$(RELEASE_VERSION)
git remote update -p
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need a tab here to get rid of the "missing separator" error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected it by adding a new line

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6f7f24db-45c4-4ec3-8b0a-0f290f759a1b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 51bd776a-5cfb-448a-a142-92296a79712c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3127/head:pr_3127 && git checkout pr_3127
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-f5b5d1f-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Apr 28, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 8a2c961 into googleforgames:main Apr 28, 2023
@Kalaiselvi84 Kalaiselvi84 deleted the issues/279954432 branch March 15, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax left review comments

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@markmandel markmandel

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New features for Agones lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kalaiselvi84 @agones-bot @markmandel @gongmax