-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Golang version 1.20.4 #3137
Conversation
Build Failed 😱 Build Id: dfb9ebf5-4800-4522-a14b-9a198d4e7854 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
59712e9
to
9bc76ad
Compare
Build Failed 😱 Build Id: 8fa1bde1-ae66-4126-a1b5-d9d0f2c69558 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
9bc76ad
to
5bdf009
Compare
Build Succeeded 👏 Build Id: f9240fd5-8a75-429b-9892-c0cd0e6a5e2a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 4e7ed519-7aba-497c-a497-0f576419f09e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, igooch The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Upgrade go version to 1.20.4
Upgrade golangci-lint to the version that introduces support of Golang 1.20
Bump example image tags minor version for examples where Go was upgraded.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer
Another PR after this will bump the example images version in the places where they are used. After this PR is merged, we need to build the new version of example images and upload the the registry, otherwise the second PR will not pass CI.