Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Build config to trigger a build if no build is running #3174

Merged
merged 2 commits into from
May 25, 2023
Merged

Cloud Build config to trigger a build if no build is running #3174

merged 2 commits into from
May 25, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented May 19, 2023 •
edited
Loading

"Always be building". Adds a short script that checks if any CI builds are running. If no CI builds are running, it starts a main build. The idea is to keep our CI clusters busy, get extra signals on flakes, etc., while not interfering during business hours.

I wired this up to the trigger here .. a manual invocation of that trigger using this PR as a branch can be found here

@zmerlynn zmerlynn force-pushed the build-if-no-build branch 6 times, most recently from fe9c37f to c2deafd Compare May 20, 2023 00:12
@zmerlynn
Add always-be-building cloud build configuration
b8b6310 
Adds a short script that checks if any CI builds are running. If no CI
builds are running, it starts a `main` build. The idea is to keep our
CI clusters busy, get extra signals on flakes, etc., while not
interfering during business hours.
@zmerlynn zmerlynn force-pushed the build-if-no-build branch from c2deafd to b8b6310 Compare May 20, 2023 00:16
@zmerlynn zmerlynn marked this pull request as ready for review May 20, 2023 00:20
@google-oss-prow google-oss-prow bot requested a review from aLekSer May 20, 2023 00:20
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7751f012-76cc-4ab3-99d3-b0b5ad58bf8b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3174/head:pr_3174 && git checkout pr_3174
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-b8b6310-amd64

@google-oss-prow google-oss-prow bot added the lgtm label May 25, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label May 25, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0b3b49dd-9d09-4d30-b3b1-5a11274ee2d2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b821b17c-5b40-4523-9b6c-14818bb227b1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3174/head:pr_3174 && git checkout pr_3174
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-b1651ea-amd64

@gongmax gongmax merged commit f324d78 into googleforgames:main May 25, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@EricFortin EricFortin Awaiting requested review from EricFortin

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@gongmax gongmax

Labels
kind/feature New features for Agones size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zmerlynn @agones-bot @gongmax @Kalaiselvi84