Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Counters and Lists to FleetAutoScaler CRD #3198

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Adds Counters and Lists to FleetAutoScaler CRD #3198

merged 5 commits into from
Jun 8, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Jun 1, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds Counters and Lists to FleetAutoScaler Custom Resource Definition.
Adds Counters and Lists to the full Fleet example.
Adds Counters and Lists FleetAutoScaler examples.
Adds Counters and Lists autoscaling policies to the FleetAutoScaler and provides validation of the policies.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

This is just the CRD and CRD validation change, and autoscaling by Counter or List does not yet work as I still need to make changes to agones/pkg/fleetautoscalers/fleetautoscalers.go which will be coming up in the next PR.

@google-oss-prow google-oss-prow bot requested review from aLekSer and cyriltovena June 1, 2023 23:50
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cca356ed-eadf-4796-a867-93a220a77718

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3198/head:pr_3198 && git checkout pr_3198
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-abbecf3-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from abbecf3 to f65842c Compare June 2, 2023 16:01
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4a7ad3a3-8258-446e-a13a-68140f886446

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from fbf46bd to 48cbb4c Compare June 2, 2023 16:10
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 42ce33a6-6941-4002-bae9-675fb249002e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e2a682bb-7ecb-4274-95e3-3b71bff3c894

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ca2cb762-c585-4801-8359-baaa76f21afb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3198/head:pr_3198 && git checkout pr_3198
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-48cbb4c-amd64

gongmax
gongmax reviewed Jun 2, 2023
View reviewed changes
examples/counterfleetautoscaler.yaml Outdated Show resolved Hide resolved
examples/counterfleetautoscaler.yaml Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Jun 2, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a27e637d-065d-43ea-90c9-b2739e879eda

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 5680e65 to 84b2326 Compare June 3, 2023 00:08
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 143ae183-4c88-4930-bd6a-d521b24afd8b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: de48ee1a-d145-4870-b9a4-943eb9c4a4ab

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 7aac357 to 68670a6 Compare June 5, 2023 05:55
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 18fa7d90-fd89-4abf-b11a-4d9c9e7c4397

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: abd58c86-4b39-4fd4-9115-602eacd7c7c6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 5a09e63 to ce05e01 Compare June 5, 2023 06:47
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 45462a65-8302-4c72-8d7f-7ff791d12c5d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3198/head:pr_3198 && git checkout pr_3198
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-5331623-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 5331623 to 892d4e7 Compare June 6, 2023 00:52
@google-oss-prow google-oss-prow bot added size/XXL and removed size/XL labels Jun 6, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5ead0fd5-46b0-4033-a974-5887cc822870

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3198/head:pr_3198 && git checkout pr_3198
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-2d31827-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 2d31827 to 4312b56 Compare June 6, 2023 20:06
@google-oss-prow google-oss-prow bot removed the size/XXL label Jun 6, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 15a4f3c1-e8fe-4bc0-86d7-1aefa0f322e6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e6ae4b96-ee54-4170-857f-1d23257b7aea

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3198/head:pr_3198 && git checkout pr_3198
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-089a48d-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Jun 6, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, igooch
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 089a48d to 0ad746f Compare June 8, 2023 18:40
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 8, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2d9c7299-c26d-43ed-8453-1c652a1711a8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3198/head:pr_3198 && git checkout pr_3198
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-0ad746f-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 0ad746f to 45cf366 Compare June 8, 2023 20:58
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3732cdff-9bd9-4f69-aa69-ae7f01eefbc0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3198/head:pr_3198 && git checkout pr_3198
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-e56fcc1-amd64

@gongmax gongmax merged commit 25f8a3a into googleforgames:main Jun 8, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Jun 25, 2023
@igooch igooch mentioned this pull request Jan 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel left review comments

@gongmax gongmax gongmax approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@gongmax gongmax

Labels
kind/feature New features for Agones size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@igooch @agones-bot @markmandel @gongmax @Kalaiselvi84