-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label changes for service-monitor #3201
Conversation
Currently looking into exactly what metrics we will be missing if we do move the labelmatching. |
Build Failed 😱 Build Id: 99f1b28a-5162-4c84-823c-5986ffff203f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 576ad7ea-4b9b-4262-b957-77adfd8e292c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Just wanted to check in, see if this needed any additional attention to help move it along. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chiayi, zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: beeae07e-ea2b-41e2-af0a-e31a9020b42c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😱 Build Id: de895adf-16de-443c-9073-b65501ef2c46 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This changes service-monitor to match against the "extensions" label when
SplitControllerAndExtensions
is enabled. \What type of PR is this?
/kind bug
What this PR does / Why we need it:
This is potential fix for #3190
Which issue(s) this PR fixes:
For #3190
Special notes for your reviewer: