Remove Feature Expiry Version Shortcodes #3210
Conversation
Kalaiselvi84
requested review from
markmandel
and removed request for
cyriltovena and
aLekSer
|
Build Failed 😱 Build Id: 313f3086-7b31-4a78-9a02-9ba364b994cf To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: dcdcfe3c-5050-4d6f-b991-19e9ca1409b1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Failed 😱 Build Id: 779f7604-6007-4d5b-be1b-6c2d96b5a5e9 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
There was a problem hiding this comment.
This is definitely looking good! Going to remove so much hand editing!
And I think once #3215 lands, we could probably also get rid of that "extra configuration" table at the bottom that makes this trickier (in fact, I'll update that PR now so that that is now gone).
Also, as per #3206 - this should be a make target as well please.
| line := scanner.Text() | ||
|
|
||
| // Check if the line contains the starting of the expiryVersion shortcode with the specified version | ||
| if strings.Contains(line, "{{% feature expiryVersion=\""+version+"\" %}}") { |
There was a problem hiding this comment.
Just so you know, you can have both {{% .... %}} as shortcode, but also {{< ... >}} shortcodes as well, so we should support both.
There was a problem hiding this comment.
I have added both shortcodes in the script and created a feature-shortcode-update target in website.mk
|
Build Succeeded 👏 Build Id: fe074d4b-725e-488a-a3e3-5e0fe911643a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| ) | ||
|
|
||
| func main() { | ||
| dirPath := "site/content/en/docs" |
There was a problem hiding this comment.
Based on my examination of the previous releases, it appears that the shortcodes are only present in the site/content/en/docs directory. Kindly inform me if there are any other directories that require the inclusion of these shortcodes.
There was a problem hiding this comment.
Nope, that's it - you got it!
|
Build Succeeded 👏 Build Id: 5ba77b92-a181-436f-9fc3-f3d8aeaf636f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kalaiselvi84, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: b3b24257-fd7c-4fe4-974e-d2fa82c9e84b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: