Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old warning of conversion int64 to float64 #3214

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

ashutosji
Copy link
Contributor

@ashutosji ashutosji commented Jun 13, 2023

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: Conversion of int64 to float64 warning doesn't require anymore. Since, Tagged issue of helm got closed. According to Agones Version chart here supported version are from 1.21 to 1.26. And officially GKE version 1.21 and earlier have reached end of life and are no longer supported.
Second Change, Pointed ref link directly to the supported version chart link instead of whole window.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 32b1c48a-a576-4756-b2e0-9b8e9145833c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3214/head:pr_3214 && git checkout pr_3214
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-4624914-amd64

@markmandel
Copy link
Member

Good catch!

@markmandel markmandel enabled auto-merge (squash) June 14, 2023 23:27
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 14, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashutosji, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashutosji, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 89c3a92b-5144-4f20-a6cd-ec5e8fdc6996

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3214/head:pr_3214 && git checkout pr_3214
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-0e5d2be-amd64

@markmandel markmandel merged commit dba66fd into googleforgames:main Jun 15, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/cleanup Refactoring code, fixing up documentation, etc label Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants