Flaky: TestAllocatorAllocatePriority

[markmandel]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Fix a flake that would see a feature flag flip just between ApplyDefaults() and Validate() -- which is more impressive than anything else.

--- FAIL: TestAllocatorAllocatePriority (1.18s)
    allocator_test.go:169:
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:169
        	            				/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:176
        	Error:      	"[spec.selectors[0].counters: Forbidden: Feature CountsAndLists must be enabled spec.selectors[0].lists: Forbidden: Feature CountsAndLists must be enabled]" should have 0 item(s), but has 2
        	Test:       	TestAllocatorAllocatePriority

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

[gongmax]

Interesting finding!

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[markmandel]

Just happened to happen to me on PR #3279!

[igooch]

This wasn't the test that flaked, it was func TestAllocatorAllocatePriority. Does this lock need to be added to all the tests?

Or should this be added to func TestAllocatorApplyAllocationToGameServerCountsListsActions after t.Parallel instead of processing for each test case?

	runtime.FeatureTestMutex.Lock()
	defer runtime.FeatureTestMutex.Unlock()
	assert.NoError(t, runtime.ParseFeatures(string(runtime.FeatureCountsAndLists)+"=true"))

[markmandel]

This wasn't the test that flaked, it was func TestAllocatorAllocatePriority. Does this lock need to be added to all the tests?

You raise a really good point! That's what I get for moving too fast.

I'll add it to the other tests this could possibly affect in this file.

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Failed 😱

Build Id: 69f98d7e-683c-4e8a-8d94-43762413eaf5

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: b5876326-b6dd-4b1f-9f0d-578b250406ea

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.34.0-dev-b27da5c-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.34.0-dev-b27da5c-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.34.0-dev-b27da5c-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.34.0-dev-b27da5c-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.34.0-dev-b27da5c-amd64
• Linux C++ SDK (build): agonessdk-1.34.0-dev-b27da5c-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.34.0-dev-b27da5c-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://b27da5c-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3280/head:pr_3280 && git checkout pr_3280
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-b27da5c-amd64