TestAllocatorAllocateOnGameServerUpdateError

[markmandel]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

This was flaking as the cache is eventually consistent, so sometimes it wouldn't be populated in time for the allocation request.

Fixed with a better state check on the allocation cache.

--- FAIL: TestAllocatorAllocateOnGameServerUpdateError (19.31s)
    allocator_test.go:499:
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:499
        	Error:      	An error is expected but got nil.
        	Test:       	TestAllocatorAllocateOnGameServerUpdateError

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agones-bot]

Build Failed 😱

Build Id: e06c028e-5c8d-48fe-897c-ed13ad97258c

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: 1ff7b39e-6719-447f-9435-0c9b4b7d639c

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

--- FAIL: TestAllocatorAllocateOnGameServerUpdateError (4.64s)
    allocator_test.go:498: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:498
        	Error:      	An error is expected but got nil.
        	Test:       	TestAllocatorAllocateOnGameServerUpdateError

Flaked again!

I ran it 100 times, it was fine 😠 .

So what is weird is it passes consistently with the private method, but not the public after it. I might have another idea to take for a spin.

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Succeeded 👏

Build Id: 7cd4d93e-37b3-47e3-ab2c-e1578d5500e7

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.34.0-dev-15a96eb-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.34.0-dev-15a96eb-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.34.0-dev-15a96eb-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.34.0-dev-15a96eb-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.34.0-dev-15a96eb-amd64
• Linux C++ SDK (build): agonessdk-1.34.0-dev-15a96eb-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.34.0-dev-15a96eb-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://15a96eb-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3283/head:pr_3283 && git checkout pr_3283
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-15a96eb-amd64