-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about which namespace is used for game serves deployed from fleets #3288
Conversation
/lgtm |
Build Succeeded 👏 Build Id: ff625070-9fdd-472c-924b-0e90cb4ba4ed The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, was just dealing with some gnarly bugs.
Really good addition! Thanks for the contribution!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, mikeseese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: 75c039fa-b88c-4db5-8a8e-0bb13949737d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: f311a70c-87c0-4594-91bf-71bc9c0c74fb The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
This PR provides additional context about where
GameServer
resources are deployed from when instantiated byFleet
's. Specifically, this addition attempts to remove confusion for those thinking that thehelm
chart valuegameservers.namespaces
changes where game servers are deployed by explicitly stating they deploy where the fleet is deployed. In the event that someone deploys aFleet
on a namespace that isn't included in thehelm
chart valuegameservers.namespaces
, they will end up receiving the error:similar to #146 and #1370 (references included for others in the same situation as me finding those posts via Google).
This PR attempts to prevent users from getting into this scenario in the first place.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This PR was the result of this Slack thread