Cloud Build script for crd-client #3290
Conversation
|
Build succeeded for crd-client in my project |
|
Build Failed 😱 Build Id: 3b683963-ecf6-4c3d-93e1-1e81ab8ba062 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
examples/crd-client/cloudbuild.yaml
Outdated
| env: | ||
| - REPOSITORY=${_REPOSITORY} | ||
| script: | | ||
| make -j 1 push |
There was a problem hiding this comment.
| make -j 1 push | |
| make push |
By default -j is 1 anyway, so seems redundant. But otherwise this looks great.
There was a problem hiding this comment.
(Same for the other examples too)
examples/crd-client/cloudbuild.yaml
Outdated
| script: | | ||
| make -j 1 push | ||
| options: | ||
| machineType: E2_HIGHCPU_32 |
There was a problem hiding this comment.
| machineType: E2_HIGHCPU_32 |
I think a standard machine will do - it'll be faster too, as the bigger machines take longer to initially spin up.
There was a problem hiding this comment.
(Same for the other examples too)
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah that's fine - there's often a longer wait for 32's to spin up too, so there is that as well.
|
Build Failed 😱 Build Id: 4822631b-595a-47a4-960b-d13354b03508 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kalaiselvi84, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: d06e295f-6323-41fd-a4e9-e550f9cf366f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #3281
Special notes for your reviewer: