Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by Priority for strategy Distributed #3296

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Sort by Priority for strategy Distributed #3296

merged 4 commits into from
Aug 11, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Jul 28, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Sorts by Priority for scheduling strategy Distributed during Game Server Allocation and Fleet autoscaling.

  • For fleet autoscaling the game servers are sorted by Priority based on Capacity, and then by a tie-breaker on game server time created.
  • For game server allocation the game servers are sorted by Priority based on Available Capacity, and then by a tie-breaker on the game server name.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Jul 28, 2023
@igooch igooch marked this pull request as ready for review July 28, 2023 22:42
@google-oss-prow google-oss-prow bot requested a review from roberthbailey July 28, 2023 22:42
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 51cda412-0f6f-480c-95bd-6c96b8c6d13c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from fe3691a to 2f891bb Compare July 31, 2023 21:40
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d7720e93-ccc8-4c8a-a708-11a782625f53

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3296/head:pr_3296 && git checkout pr_3296
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-2f891bb-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 2f891bb to 6f697f2 Compare July 31, 2023 22:33
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 73ec2a37-6318-4033-8680-48e7f249c2f0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 6f697f2 to 63169e9 Compare July 31, 2023 23:26
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 39bd3079-1537-47fe-b413-62fc8085b77f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 63169e9 to e552977 Compare August 7, 2023 18:01
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: edf5c7a4-2692-4f22-af40-0cb20d83829f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 439d676 to f06ca2d Compare August 7, 2023 22:18
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c2b4adb9-fb55-4606-a79d-19a382ddc9c8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 580639f2-28d2-40e9-99aa-2cbbf2adaa72

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3296/head:pr_3296 && git checkout pr_3296
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-f06ca2d-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from f06ca2d to bb4d245 Compare August 8, 2023 16:32
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a21fd5d5-6c27-4406-905d-879eb2c782e8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3296/head:pr_3296 && git checkout pr_3296
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-bb4d245-amd64

gongmax
gongmax reviewed Aug 8, 2023
View reviewed changes
pkg/gameserverallocations/allocation_cache.go Outdated Show resolved Hide resolved
pkg/gameserverallocations/find_test.go Show resolved Hide resolved
pkg/gameserversets/gameserversets.go Outdated Show resolved Hide resolved
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from bb4d245 to 205fb08 Compare August 9, 2023 16:02
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b52ee248-364f-4a2b-b31a-ec10b05f772c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3296/head:pr_3296 && git checkout pr_3296
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-205fb08-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fbe15fad-bd83-4d13-8256-b8cec4fb1b67

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3296/head:pr_3296 && git checkout pr_3296
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-3080c8f-amd64

@markmandel
Copy link
Member

This LGTM, so unless you have any issues @gongmax I think this is good to merge?

@google-oss-prow google-oss-prow bot added the lgtm label Aug 11, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, igooch
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongmax
Copy link
Collaborator

gongmax commented Aug 11, 2023

LGTM

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Aug 11, 2023
@markmandel markmandel enabled auto-merge (squash) August 11, 2023 18:32
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6011f902-9a3d-46e0-ab27-e41a82de0fc7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3296/head:pr_3296 && git checkout pr_3296
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-f913d45-amd64

@markmandel markmandel merged commit 181481a into googleforgames:main Aug 11, 2023
@igooch igooch mentioned this pull request Jan 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@markmandel markmandel Awaiting requested review from markmandel

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@gongmax gongmax

Labels
kind/feature New features for Agones size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igooch @agones-bot @markmandel @gongmax