Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SDK Conformance error reporting #3331

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Improve SDK Conformance error reporting #3331

merged 4 commits into from
Aug 18, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Attempting to make it easier to see when and how SDK conformance tests either pass or fail.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

@markmandel
Improve SDK Conformance error reporting
81a13e1 
Attempting to make it easier to see when and how SDK conformance tests
either pass or fail.
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Aug 17, 2023
@markmandel markmandel mentioned this pull request Aug 17, 2023
Closed
zmerlynn
zmerlynn reviewed Aug 17, 2023
View reviewed changes
build/includes/sdk.mk Outdated
$(MAKE) run-sdk-conformance-no-build && echo "+++ Success: $(SDK_FOLDER)" && break || \
status=$$? && echo "*** Failure: $(SDK_FOLDER), try $$try/$(TRIES)"; \
@for try in `seq 1 $(TRIES)`; do \
$(MAKE) run-sdk-conformance-no-build && echo "\n\n+++ Success: $(SDK_FOLDER)\n\n" && break || \
Copy link
Collaborator

@zmerlynn zmerlynn Aug 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe emit the try count on success as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fb9a3649-b516-45f1-930f-cfaf9418f49a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3331/head:pr_3331 && git checkout pr_3331
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-81a13e1-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: eae24f8a-aafa-47dd-b8de-18589e608119

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3331/head:pr_3331 && git checkout pr_3331
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-bee7182-amd64

@markmandel
* Added headers for building
7a705cf 
* Changed to recurse grouping, to see if that's better.
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Aug 17, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 41c0cc1a-aeea-4d9a-ac57-b49eca2f9441

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3331/head:pr_3331 && git checkout pr_3331
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-7a705cf-amd64

@markmandel markmandel marked this pull request as ready for review August 17, 2023 23:53
@google-oss-prow google-oss-prow bot requested a review from cyriltovena August 17, 2023 23:54
@markmandel
Copy link
Member Author

I think this is better. Although I haven't tested what happens on a failure, since I haven't seen one happen yet.

@markmandel markmandel requested a review from hongalex August 17, 2023 23:54
@google-oss-prow google-oss-prow bot added the lgtm label Aug 18, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Aug 18, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@zmerlynn zmerlynn enabled auto-merge (squash) August 18, 2023 16:10
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5bd34b2b-7f42-48b0-a41e-698e0c6553b1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3331/head:pr_3331 && git checkout pr_3331
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-999c785-amd64

@zmerlynn zmerlynn merged commit fc0e07d into googleforgames:main Aug 18, 2023
@markmandel markmandel deleted the update/better-sdk-conformance-reporting branch August 21, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerlynn zmerlynn zmerlynn approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@hongalex hongalex Awaiting requested review from hongalex

Assignees

@zmerlynn zmerlynn

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @zmerlynn