GKE Autopilot: Add support for Extended Duration pods #3387
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Failed 😱 Build Id: 03978250-f46d-4c1f-b726-02454fc89e07 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: 027d34f9-a726-4a5b-b540-ba41bdb2a57b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
zmerlynn
force-pushed
the
version-aware-cloud-product
branch
from
ddcd2f2 to
8844271
Compare
|
Build Failed 😱 Build Id: 3495db2c-89e7-49e6-ab11-774e33026414 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
The e2e issue seems real, moving this back to draft for now. |
|
Build Failed 😱 Build Id: 08e903d9-71a9-47d9-9a4f-217a28d5f793 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: 182dc4e2-92c7-4030-9ae6-b122fb9b4dfd To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
zmerlynn
changed the title
|
(This is shelved for the time being.) |
zmerlynn
removed request for
markmandel,
cyriltovena,
roberthbailey and
igooch
|
Build Failed 😱 Build Id: a1bd1e0c-30ae-487d-b14c-0d4a2419e02d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: 75c88fd2-9b08-49b5-b945-3d332d6e786d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
zmerlynn
force-pushed
the
version-aware-cloud-product
branch
2 times, most recently
from
893638c to
10973dd
Compare
zmerlynn
changed the title
|
Build Succeeded 👏 Build Id: 9d1d6f1f-2dce-4007-a444-b1e377867acf The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
… gate Introduces Extended Duration Pod support for Autopilot under feature gate "GKEAutopilotExtendedDurationPods". This feature has some rough edges with Agones on Autopilot 1.27, so I'm introducing this as a dev feature gate until we sort everything out. ED pods have the same UI as disabling Autopilot on GKE Standard [1]: annotate with `cluster-autoscaler.kubernetes.io/safe-to-evict=false` and your pod is protected from eviction. However, Autopilot handles node upgrades specially and just autoscales new nodes at new versions, so the concept of "safe to evict on upgrade" is unnecessary. Since we can support the concept and do nothing really special, do so: We pull out the "generic" implementation of SetEviction into cloudproduct/eviction and call that. [1] https://cloud.google.com/kubernetes-engine/docs/how-to/extended-duration-pods Towards googleforgames#3366
zmerlynn
force-pushed
the
version-aware-cloud-product
branch
from
10973dd to
fa7c006
Compare
|
Build Succeeded 👏 Build Id: bf69aace-21f3-4e6f-9b1a-9e97db021ab8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: 1a2e33c3-c7b4-444a-a30e-44b04cde1b7a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Introduces Extended Duration Pod support for Autopilot under feature gate "GKEAutopilotExtendedDurationPods". This feature has some rough edges with Agones on Autopilot 1.27, so I'm introducing this as a dev feature gate until we sort everything out.
ED pods have the same UI as disabling Autopilot on GKE Standard [1]: annotate with
cluster-autoscaler.kubernetes.io/safe-to-evict=falseand your pod is protected from eviction. However, Autopilot handles node upgrades specially and just autoscales new nodes at new versions, so the concept of "safe to evict on upgrade" is unnecessary. Since we can support the concept and do nothing really special, do so: We pull out the "generic" implementation of SetEviction into cloudproduct/eviction and call that.[1] https://cloud.google.com/kubernetes-engine/docs/how-to/extended-duration-pods
Towards #3386
Note to reviewers: This change is not as big as it seems - it's mostly refactoring.