Reduce controller memory footprint considerably #3394
Conversation
In the past it wasn't deemed necessary to give the sub-controllers of the GameServer controller (Health, Missing and Migration) more than 1 worker for their queues, as speed of processing wasn't hugely important for their particular workloads. An unfortunate consequence of that is that their queues can back up quite significantly, since they can't process events very fast at all. causing big jumps in memory usage. This change brings those controllers in line with all the others, such that they have the same number of workers as every other controller - and now we have a much more stable memory footprint for the controller since they can process their incoming events in a timely manner. Closes googleforgames#3380
markmandel
added
area/user-experience
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You ask an interesting question, so I went back and looked at the metrics! Interestingly, it's actually a little less! I wonder if having all that memory backing up makes things difficult for the CPU and/or also garbage collection.
|
|
@Kalaiselvi84 this would be a good one to have in the release notes for sure 👍🏻 |
|
Build Succeeded 👏 Build Id: e6305fea-1736-4938-974c-cdb09ec0aa74 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 558342be-407f-4002-8ef3-7840081ee663 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
In the past it wasn't deemed necessary to give the sub-controllers of the GameServer controller (Health, Missing and Migration) more than 1 worker for their queues, as speed of processing wasn't hugely important for their particular workloads.
An unfortunate consequence of that is that their queues can back up quite significantly, since they can't process events very fast at all. causing big jumps in memory usage.
This change brings those controllers in line with all the others, such that they have the same number of workers as every other controller - and now we have a much more stable memory footprint for the controller since they can process their incoming events in a timely manner.
Which issue(s) this PR fixes:
Closes #3380
Special notes for your reviewer:
Added a couple of extra checks to queuing as well.