Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake: TestGameServerAllocationValidate #3443

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Moving the FeatureMutexLock so that it covers the top part of the test which can flake if feature flags are not set as expected.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Flake: #3442 (comment)

Moving the FeatureMutexLock so that it covers the top part of the test
which can flake if feature flags are not set as expected.
@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Oct 19, 2023
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 19, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) October 20, 2023 00:07
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9daa500f-00b3-410d-ab95-9e3702e19741

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3443/head:pr_3443 && git checkout pr_3443
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-fd9be7e-amd64

@markmandel markmandel merged commit c574a89 into googleforgames:main Oct 20, 2023
2 checks passed
@markmandel markmandel deleted the flake/TestGameServerAllocationValidate branch October 20, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants