Update fleet autoscaling limited signification(#2828)

[atgane]

What type of PR is this?:

/kind documentation

What this PR does / Why we need it:

• On FleetAutoScaler scalingLimited is reporting the incorrect state #2828 , we found that user can easily misunderstand the meaning of ScalingLimited.

• It's actually ScalingUpOrDownLimited in applyBufferPolicy(). It works like above image:

• ✅ So I want to change grafana metric title ScalingLimited to Scaling Down or Up Limited and enhance code readability

Which issue(s) this PR fixes:

• Closes FleetAutoScaler scalingLimited is reporting the incorrect state #2828

Special notes for your reviewer: N/A

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[agones-bot]

Build Succeeded 👏

Build Id: aa917877-851e-431c-bb1c-0141f9e7639b

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.36.0-dev-bbb0d4e-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.36.0-dev-bbb0d4e-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.36.0-dev-bbb0d4e-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.36.0-dev-bbb0d4e-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.36.0-dev-bbb0d4e-amd64
• Linux C++ SDK (build): agonessdk-1.36.0-dev-bbb0d4e-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.36.0-dev-bbb0d4e-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://bbb0d4e-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3448/head:pr_3448 && git checkout pr_3448
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-bbb0d4e-amd64

[gongmax]

nitpick but scale out/in sounds more suitable here.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atgane, gongmax
Once this PR has been reviewed and has the lgtm label, please assign alekser for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Succeeded 👏

Build Id: 269596b9-d025-4151-a1da-7347bcaae6de

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.36.0-dev-41921b3-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.36.0-dev-41921b3-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.36.0-dev-41921b3-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.36.0-dev-41921b3-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.36.0-dev-41921b3-amd64
• Linux C++ SDK (build): agonessdk-1.36.0-dev-41921b3-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.36.0-dev-41921b3-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://41921b3-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3448/head:pr_3448 && git checkout pr_3448
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-41921b3-amd64

[gongmax]

Sorry for the back and forth but better to change this and line 233, 236 too for consistency

[agones-bot]

Build Failed 😱

Build Id: b19463c9-6c5f-4a0d-bb04-f0e851d4bf2f

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: ab4f6983-3d91-4363-a4fa-dfd7187d3152

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 2ddcc15e-06d6-4957-a847-9c0ce7dbe931

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.36.0-dev-81ba000-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.36.0-dev-81ba000-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.36.0-dev-81ba000-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.36.0-dev-81ba000-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.36.0-dev-81ba000-amd64
• Linux C++ SDK (build): agonessdk-1.36.0-dev-81ba000-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.36.0-dev-81ba000-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://81ba000-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3448/head:pr_3448 && git checkout pr_3448
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-81ba000-amd64