Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang Version to go1.20.10 #3475

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Golang Version to go1.20.10 #3475

merged 1 commit into from
Oct 30, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3471

Special notes for your reviewer:

@google-oss-prow google-oss-prow bot requested a review from cyriltovena October 30, 2023 19:52
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 30, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 281c5470-231a-4efa-bb14-9ae55aab663a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 37caa59f-a6b2-41ea-82ad-5c30cbd5ce06

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3475/head:pr_3475 && git checkout pr_3475
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-cbced9d-amd64

@markmandel
Copy link
Member

@Kalaiselvi84 just triple checking before merging - all the new example images are uploaded to prod, yep?

markmandel
markmandel approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind - I can check this myself!

❯ make test-examples-on-gar
docker run --rm -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones  agones-build:83141ac095 bash -c "cd examples/allocation-endpoint && make gar-check"
gcloud container images describe us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.6
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:f1b4369f2ee929d09ed1db0904d2dacd5efae5208fb6cc36ed9a6407b9aae1fb
  fully_qualified_digest: us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy@sha256:f1b4369f2ee929d09ed1db0904d2dacd5efae5208fb6cc36ed9a6407b9aae1fb
  registry: us-docker.pkg.dev
  repository: agones-images/examples/allocation-endpoint-proxy
docker run --rm -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones  agones-build:83141ac095 bash -c "cd examples/autoscaler-webhook && make gar-check"
gcloud container images describe us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.9
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:fb882444933229e40f9197d97f0c0a3b606b00b86f8425f276cb7d0f46a0d441
  fully_qualified_digest: us-docker.pkg.dev/agones-images/examples/autoscaler-webhook@sha256:fb882444933229e40f9197d97f0c0a3b606b00b86f8425f276cb7d0f46a0d441
  registry: us-docker.pkg.dev
  repository: agones-images/examples/autoscaler-webhook
docker run --rm -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones  agones-build:83141ac095 bash -c "cd examples/cpp-simple && make gar-check"
gcloud container images describe us-docker.pkg.dev/agones-images/examples/cpp-simple-server:0.16
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:b408219fa322ee9d16378b9cae2c0f5cacb05b4dbdb4de279e36fda9d9fab39d
  fully_qualified_digest: us-docker.pkg.dev/agones-images/examples/cpp-simple-server@sha256:b408219fa322ee9d16378b9cae2c0f5cacb05b4dbdb4de279e36fda9d9fab39d
  registry: us-docker.pkg.dev
  repository: agones-images/examples/cpp-simple-server
docker run --rm -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones  agones-build:83141ac095 bash -c "cd examples/nodejs-simple && make gar-check"
gcloud container images describe us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.9
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:2855444d9e27a11e1d066662314d653954e4b5062a361adb4a08ff33e01899f3
  fully_qualified_digest: us-docker.pkg.dev/agones-images/examples/nodejs-simple-server@sha256:2855444d9e27a11e1d066662314d653954e4b5062a361adb4a08ff33e01899f3
  registry: us-docker.pkg.dev
  repository: agones-images/examples/nodejs-simple-server
docker run --rm -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones  agones-build:83141ac095 bash -c "cd examples/rust-simple && make gar-check"
gcloud container images describe us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.12
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:a67e9b32a46594637028d6ce8a039ab0199335a28256c2448690649f9a1406fe
  fully_qualified_digest: us-docker.pkg.dev/agones-images/examples/rust-simple-server@sha256:a67e9b32a46594637028d6ce8a039ab0199335a28256c2448690649f9a1406fe
  registry: us-docker.pkg.dev
  repository: agones-images/examples/rust-simple-server
docker run --rm -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones  agones-build:83141ac095 bash -c "cd examples/unity-simple && make gar-check"
gcloud container images describe us-docker.pkg.dev/agones-images/examples/unity-simple-server:0.3
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:91d5f2d61df93795f50e78406424ca04d82a347bf757594159dfd1145cbb805c
  fully_qualified_digest: us-docker.pkg.dev/agones-images/examples/unity-simple-server@sha256:91d5f2d61df93795f50e78406424ca04d82a347bf757594159dfd1145cbb805c
  registry: us-docker.pkg.dev
  repository: agones-images/examples/unity-simple-server
docker run --rm -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones  agones-build:83141ac095 bash -c "cd examples/xonotic && make gar-check"
gcloud container images describe us-docker.pkg.dev/agones-images/examples/xonotic-example:1.4
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:989c987a0a151cd89805301a31c2b0fc932abd076fea5a44b4ca100b7862836c
  fully_qualified_digest: us-docker.pkg.dev/agones-images/examples/xonotic-example@sha256:989c987a0a151cd89805301a31c2b0fc932abd076fea5a44b4ca100b7862836c
  registry: us-docker.pkg.dev
  repository: agones-images/examples/xonotic-example
docker run --rm -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones  agones-build:83141ac095 bash -c "cd examples/crd-client && make gar-check"
gcloud container images describe us-docker.pkg.dev/agones-images/examples/crd-client:0.12
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:5267afc759af82e98434988da7cfb215a68e0d13e76f0e806a5d10443af966fb
  fully_qualified_digest: us-docker.pkg.dev/agones-images/examples/crd-client@sha256:5267afc759af82e98434988da7cfb215a68e0d13e76f0e806a5d10443af966fb
  registry: us-docker.pkg.dev
  repository: agones-images/examples/crd-client
docker run --rm -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones  agones-build:83141ac095 bash -c "cd examples/supertuxkart && make gar-check"
gcloud container images describe us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.10
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:45e33db434864c21f257344afee40d12cb3da2c58af5041543180bd2cd58866f
  fully_qualified_digest: us-docker.pkg.dev/agones-images/examples/supertuxkart-example@sha256:45e33db434864c21f257344afee40d12cb3da2c58af5041543180bd2cd58866f
  registry: us-docker.pkg.dev
  repository: agones-images/examples/supertuxkart-example
docker run --rm -v /home/markmandel/workspace/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /home/markmandel/workspace/agones:/go/src/agones.dev/agones -v /home/markmandel/workspace/agones/build//.gomod:/go/pkg/mod -v /home/markmandel/workspace/agones/build//.gocache:/root/.cache/go-build -e "KUBECONFIG=/root/.kube/config" -e "GO111MODULE=on" -w /go/src/agones.dev/agones  agones-build:83141ac095 bash -c "cd examples/simple-game-server && make gar-check"
gcloud container images describe us-docker.pkg.dev/agones-images/examples/simple-game-server:0.21
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:178da7a54e64393aa19ee609525bf4e73b91510b4b94cfa2b6b0f8653c671931
  fully_qualified_digest: us-docker.pkg.dev/agones-images/examples/simple-game-server@sha256:178da7a54e64393aa19ee609525bf4e73b91510b4b94cfa2b6b0f8653c671931
  registry: us-docker.pkg.dev
  repository: agones-images/examples/simple-game-server

@google-oss-prow google-oss-prow bot added the lgtm label Oct 30, 2023
@markmandel markmandel merged commit dfd7e6b into googleforgames:main Oct 30, 2023
2 checks passed
@markmandel markmandel deleted the go-v1.20.10 branch October 30, 2023 22:26
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kalaiselvi84
Copy link
Contributor Author

@Kalaiselvi84 just triple checking before merging - all the new example images are uploaded to prod, yep?

yes, we have a new tag for 4 example images:

autoscaler-webhook:0.9
crd-client:0.12
simple-game-server:0.21
supertuxkart-example:0.10
xonotic-example:1.4

@Kalaiselvi84
Copy link
Contributor Author

oh no, this PR already merged😅

@markmandel markmandel restored the go-v1.20.10 branch October 31, 2023 18:53
@Kalaiselvi84 Kalaiselvi84 deleted the go-v1.20.10 branch March 15, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@igooch igooch Awaiting requested review from igooch

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@markmandel markmandel

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Golang Version to go1.20.10
3 participants
@Kalaiselvi84 @agones-bot @markmandel