Test NodeJS image #3498

Kalaiselvi84 · 2023-11-09T18:37:57Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3481

Special notes for your reviewer:

agones-bot · 2023-11-09T19:55:53Z

Build Failed 😱

Build Id: b4106d42-ba70-4106-b983-fbfa16eaeefa

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-11-09T22:52:13Z

Build Failed 😱

Build Id: 5771a8b5-796f-4423-bdda-a9d8d1b88935

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-11-10T02:35:25Z

Build Failed 😱

Build Id: c487619b-1123-4cc7-a14a-ab06586551e7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-11-10T21:05:52Z

Looks like a legit error:

time="2023-11-10 02:25:15.752" level=info msg="Checking Fleet Ready replicas" expected=3 fleet=simple-fleet-1.0q5sw4 fleetStatus="{Replicas:3 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:0xc000a58c50 Counters:map[] Lists:map[]}" test=TestFleetStrategyValidation
    examples_test.go:134: 
        	Error Trace:	/go/src/agones.dev/agones/test/e2e/examples_test.go:134
        	Error:      	Received unexpected error:
        	            	waiting for { [{default Dynamic <nil> 7654 0 UDP}] {false 25 0 30}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] []} {[] [] [{nodejs-simple us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.9 [] []  [] [] [] {map[] map[] []} [] [] [] nil nil nil nil    nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil> nil <nil> [] []}} <nil> map[] map[] <nil>} GameServer instance readiness timed out (): waiting for GameServer 1699582568/nodejs-simple-dtzjt to be Ready: GameServer reached terminal state Unhealthy
        	Test:       	TestNodeJSGameServerReady
--- FAIL: TestNodeJSGameServerReady (128.44s)

test/e2e/examples_test.go

Kalaiselvi84 · 2023-11-10T21:27:33Z

Looks like a legit error:

time="2023-11-10 02:25:15.752" level=info msg="Checking Fleet Ready replicas" expected=3 fleet=simple-fleet-1.0q5sw4 fleetStatus="{Replicas:3 ReadyReplicas:0 ReservedReplicas:0 AllocatedReplicas:0 Players:0xc000a58c50 Counters:map[] Lists:map[]}" test=TestFleetStrategyValidation
    examples_test.go:134: 
        	Error Trace:	/go/src/agones.dev/agones/test/e2e/examples_test.go:134
        	Error:      	Received unexpected error:
        	            	waiting for { [{default Dynamic <nil> 7654 0 UDP}] {false 25 0 30}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] []} {[] [] [{nodejs-simple us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.9 [] []  [] [] [] {map[] map[] []} [] [] [] nil nil nil nil    nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil> nil <nil> [] []}} <nil> map[] map[] <nil>} GameServer instance readiness timed out (): waiting for GameServer 1699582568/nodejs-simple-dtzjt to be Ready: GameServer reached terminal state Unhealthy
        	Test:       	TestNodeJSGameServerReady
--- FAIL: TestNodeJSGameServerReady (128.44s)

I am not able to see this error in the log.🤔 are you receiving it in your local?
This test is passing in my local - https://screenshot.googleplex.com/3VGMdhnaQUhJMSE

…nodejs

agones-bot · 2023-11-10T23:37:24Z

Build Failed 😱

Build Id: 84294d98-ef2d-4bce-84f5-5d13947868bb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

test/e2e/examples_test.go

agones-bot · 2023-11-11T03:25:48Z

Build Failed 😱

Build Id: 00dc9d73-7b89-47f6-8359-7a1bff00d50f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-11-11T05:46:19Z

Build Succeeded 👏

Build Id: 183ce603-28df-4b92-9ed7-f7bc4b5641ab

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://d3a4537-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3498/head:pr_3498 && git checkout pr_3498
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-d3a4537-amd64

markmandel · 2023-11-13T22:25:23Z

test/e2e/examples_test.go

+			Health: agonesv1.Health{
+				InitialDelaySeconds: 300,
+				PeriodSeconds:       25,
+			},


Can you do me a favour - can we remove the Health settings, and we can test without it?

Suggested change

Health: agonesv1.Health{

InitialDelaySeconds: 300,

PeriodSeconds: 25,

},

We shouldn't have to make them so long now, since it looks like it was a resource setting issue that we fixed below.

Removing this health settings indicated that the GameServer reached a terminal 'Unhealthy' state upon testing- https://gist.github.com/Kalaiselvi84/8d7a212a93c04291d42f90476c0fcb7f

Even with the resource settings?

Yep! it fails with resource and without health.

Oh yeah it would! Because it does't make health calls very often!

Okay, let's try a small number - probably:

Health: agonesv1.Health{ InitialDelaySeconds: 30, PeriodSeconds: 30, },

Should be a good fit.

markmandel · 2023-11-13T22:48:52Z

test/e2e/examples_test.go

 	t.Parallel()
 	gs := &agonesv1.GameServer{
 		ObjectMeta: metav1.ObjectMeta{
-			GenerateName: "rust-simple-",
+			GenerateName: "cpp-simple-",


I just noticed this here switched from Rus to CPP - was that deliberate?

I tried to keep the e2e tests in the order you mentioned in the ticket - https://buganizer.corp.google.com/issues/309492114#comment1

The order doesn't matter at all. You can revert these changes 👍🏻

agones-bot · 2023-11-14T01:02:27Z

Build Succeeded 👏

Build Id: 38dfcea2-1139-43a9-88d8-e8865e77bd31

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://490892f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3498/head:pr_3498 && git checkout pr_3498
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-490892f-amd64

google-oss-prow · 2023-11-14T01:03:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kalaiselvi84, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Test NodeJS image

fd47909

Kalaiselvi84 requested a review from markmandel November 9, 2023 18:37

google-oss-prow bot requested review from EricFortin and roberthbailey November 9, 2023 18:38

google-oss-prow bot added the size/M label Nov 9, 2023

github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Nov 9, 2023

resolve conflict

dde62a9

Kalaiselvi84 and others added 2 commits November 10, 2023 01:09

resolve conflict

440d299

Merge branch 'main' into nodejs

3d34e7a

markmandel reviewed Nov 10, 2023

View reviewed changes

test/e2e/examples_test.go Show resolved Hide resolved

Kalaiselvi84 added 3 commits November 10, 2023 21:29

increase InitialDelaySeconds

b6684de

Merge branch 'nodejs' of https://github.com/Kalaiselvi84/agones into …

486178a

…nodejs

resolve conflict

4fe8a2d

markmandel reviewed Nov 11, 2023

View reviewed changes

test/e2e/examples_test.go Outdated Show resolved Hide resolved

resources included

1150d30

lint

d3a4537

markmandel reviewed Nov 13, 2023

View reviewed changes

removed heath settings

4919f01

markmandel reviewed Nov 13, 2023

View reviewed changes

Kalaiselvi84 added 2 commits November 13, 2023 23:27

included health and e2e function order change

006dde2

Merge branch 'main' into nodejs

490892f

markmandel approved these changes Nov 14, 2023

View reviewed changes

markmandel merged commit 75ad796 into googleforgames:main Nov 14, 2023
3 checks passed

google-oss-prow bot assigned markmandel Nov 14, 2023

google-oss-prow bot added the lgtm label Nov 14, 2023

google-oss-prow bot added the approved label Nov 14, 2023

Kalaiselvi84 deleted the nodejs branch March 15, 2024 01:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test NodeJS image #3498

Test NodeJS image #3498

Kalaiselvi84 commented Nov 9, 2023

agones-bot commented Nov 9, 2023

agones-bot commented Nov 9, 2023

agones-bot commented Nov 10, 2023

markmandel commented Nov 10, 2023

Kalaiselvi84 commented Nov 10, 2023

agones-bot commented Nov 10, 2023

agones-bot commented Nov 11, 2023

agones-bot commented Nov 11, 2023

markmandel Nov 13, 2023

Kalaiselvi84 Nov 13, 2023

markmandel Nov 13, 2023

Kalaiselvi84 Nov 13, 2023

markmandel Nov 13, 2023

markmandel Nov 13, 2023

Kalaiselvi84 Nov 13, 2023

markmandel Nov 13, 2023

agones-bot commented Nov 14, 2023

google-oss-prow bot commented Nov 14, 2023

Test NodeJS image #3498

Test NodeJS image #3498

Conversation

Kalaiselvi84 commented Nov 9, 2023

agones-bot commented Nov 9, 2023

agones-bot commented Nov 9, 2023

agones-bot commented Nov 10, 2023

markmandel commented Nov 10, 2023

Kalaiselvi84 commented Nov 10, 2023

agones-bot commented Nov 10, 2023

agones-bot commented Nov 11, 2023

agones-bot commented Nov 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Nov 14, 2023

google-oss-prow bot commented Nov 14, 2023