Move SplitControllerAndExtensions to Stable

[Kalaiselvi84]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3513

Special notes for your reviewer:

[agones-bot]

Build Failed 😱

Build Id: 257045cc-24a3-4425-be2b-51fede3c6639

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: ab945e6e-c7fb-4438-b74e-ee7494c78e6b

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Aha! Found it!

docker run --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build  agones-build:83141ac095 bash -c \
	'helm template agones-manual --namespace agones-system /go/src/agones.dev/agones/install/helm/agones \
	--set agones.controller.generateTLS=false \
	--set agones.allocator.generateTLS=false \
	--set agones.allocator.generateClientTLS=false \
	--set agones.crds.cleanupOnDelete=false \
	> /go/src/agones.dev/agones/install/yaml/install.yaml'
make[1]: Leaving directory '/workspace/build'
sort /workspace/install/yaml/install.yaml > /tmp/agones-install/install.current.yaml.sorted
diff /tmp/agones-install/install.yaml.sorted /tmp/agones-install/install.current.yaml.sorted
7a8,9
> 
> 
make: *** [Makefile:408: test-install-yaml] Error 1
make: *** Waiting for unfinished jobs....

Need to run make gen-install 😄

[Kalaiselvi84]

Need to run make gen-install 😄

This command added two extra spaces. Could this be causing the build to fail?🤔

[agones-bot]

Build Succeeded 👏

Build Id: a2088f26-db63-4828-ad16-534819c5c577

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.37.0-dev-e3cfe0e-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.37.0-dev-e3cfe0e-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-e3cfe0e-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.37.0-dev-e3cfe0e-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.37.0-dev-e3cfe0e-amd64
• Linux C++ SDK (build): agonessdk-1.37.0-dev-e3cfe0e-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.37.0-dev-e3cfe0e-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://e3cfe0e-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3523/head:pr_3523 && git checkout pr_3523
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-e3cfe0e-amd64

[markmandel]

This command added two extra spaces. Could this be causing the build to fail?🤔

Yeah it will - any difference will cause it to fail 👍🏻

[markmandel]

Except for one question, this looks good to me. @zmerlynn can you also look over as well please, since you are more familiar with this work?

[zmerlynn]

Looks great! Sorry I missed this earlier.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kalaiselvi84, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign roberthbailey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Succeeded 👏

Build Id: 25cf38aa-5ca4-4adf-b439-44d7d3234021

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.37.0-dev-8ac81d9-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.37.0-dev-8ac81d9-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-8ac81d9-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.37.0-dev-8ac81d9-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.37.0-dev-8ac81d9-amd64
• Linux C++ SDK (build): agonessdk-1.37.0-dev-8ac81d9-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.37.0-dev-8ac81d9-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://8ac81d9-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3523/head:pr_3523 && git checkout pr_3523
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-8ac81d9-amd64

[agones-bot]

Build Failed 😱

Build Id: 246a3ba2-b61a-4e12-a13c-3c62ba2c2f68

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Oooh, we got some link failures! You can run make lint to test locally.

[Kalaiselvi84]

Oooh, we got some link failures! You can run make lint to test locally.

Fixed it. Something messed up when resolving the conflict.

[agones-bot]

Build Succeeded 👏

Build Id: 5e993187-845d-4447-8a83-bc54db33085d

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.37.0-dev-2c21187-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.37.0-dev-2c21187-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-2c21187-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.37.0-dev-2c21187-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.37.0-dev-2c21187-amd64
• Linux C++ SDK (build): agonessdk-1.37.0-dev-2c21187-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.37.0-dev-2c21187-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://2c21187-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3523/head:pr_3523 && git checkout pr_3523
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-2c21187-amd64