Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudBuild: Fix for cache image rebuild #3535

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Somewhere substitutions got lost, adding it back in. I think that will solve my issue with creating a scheduled trigger. Will need to merge before I can test it.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Somewhere `substitutions` got lost, adding it back in. I think that will
solve my issue with creating a scheduled trigger. Will need to merge
before I can test it.
@markmandel markmandel added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Dec 7, 2023
@github-actions github-actions bot added kind/bug These are bugs. size/XS labels Dec 7, 2023
@@ -137,6 +137,9 @@ steps:
- name: original
path: /original

substitutions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh right! I was initially adding this substitution in the target, but we later decided not to use any target

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1aec182b-9f20-4d8c-8ff7-7cc74028fa8b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3535/head:pr_3535 && git checkout pr_3535
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-b5894e9-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ace51744-b169-40eb-8adf-56efec59d7a1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3535/head:pr_3535 && git checkout pr_3535
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-7974591-amd64

@markmandel markmandel merged commit d758420 into googleforgames:main Dec 8, 2023
4 checks passed
@markmandel markmandel deleted the build/rebuild-cache branch December 8, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/bug These are bugs. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants