Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go CRD Comment Updates for Counters and Lists #3536

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Updated some comments on the Counter and Lists with an aim to make the generated reference document more readable and provide more context of the operations therein.

Which issue(s) this PR fixes:

Work on #2716

Special notes for your reviewer:

Noted some things that stood out as small quality of life improvements in comments. Non blocking for this release, but if we like them, let's create issues / track them in #2716 to be updated in the next one.

Updated some comments on the Counter and Lists with an aim to make the
generated reference document more readable and provide more context of
the operations therein.

Work on googleforgames#2716
Copy link

github-actions bot commented Dec 9, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a2275499-9845-4beb-9cad-c93a705b5aae

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3536/head:pr_3536 && git checkout pr_3536
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-8212fbc-amd64

@gongmax gongmax merged commit e5d89bc into googleforgames:main Dec 11, 2023
4 checks passed
@markmandel markmandel deleted the crd/doc-updates branch December 12, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Documentation for Agones size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants