Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase performance test cluster size #3559

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Increase performance test cluster size #3559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/terraform/performance/module.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ module "gke_standard_cluster" {
location = each.value[0]
overrideName = format("standard-performance-test-cluster-%s", replace(each.key, ".", "-"))
releaseChannel = each.value[1]
machineType = "n2-standard-2"
initialNodeCount = 300
machineType = "e2-standard-4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to double the number of cores in the test cluster. Do you have autoscaling enabled to scale the number of nodes down when it isn't in use?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't make it quite clear in the PR description. The current test cluster is already using type "e2-standard-4" actually. The code here drifted from the fact by some mistake. So the only actual change in this PR is to increase the size to 310.
Good point to enable autoscaling. I will test and make a quick follow up PR for it.

initialNodeCount = 310
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To piggyback on the above point, if we enable node autoscaling, then we should adjust the max number of allowed nodes as the initial node count wouldn't make any difference.

}

resource "google_compute_firewall" "udp" {
Expand Down